Skip to content

Reordering #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

Reordering #386

merged 1 commit into from
Sep 9, 2024

Conversation

mroda88
Copy link
Contributor

@mroda88 mroda88 commented Sep 9, 2024

As we mentioned in many meetings before, we need opmonlib to depend on OKS.
This PRs changes the compilation order to allow this.

No changes are required in the CMakeList files in any of the repositories.

@mroda88 mroda88 added the dependencies Pull requests that update a dependency file label Sep 9, 2024
@mroda88 mroda88 self-assigned this Sep 9, 2024
jcfreeman2
jcfreeman2 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@jcfreeman2 jcfreeman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that in the v5 line, every package which depends on opmonlib in its CMakeLists.txt file comes after opmonlib in dbt-build-order.cmake, and every package opmonlib depends on in its CMakeLists.txt file comes before.

@jcfreeman2 jcfreeman2 merged commit d8d1c7a into develop Sep 9, 2024
1 check passed
@jcfreeman2 jcfreeman2 deleted the mroda/reordering branch September 9, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfreeman2 jcfreeman2 jcfreeman2 approved these changes

@andrewmogan andrewmogan Awaiting requested review from andrewmogan

Assignees

@mroda88 mroda88

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroda88 @jcfreeman2