Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of branch_name variable #363

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

andrewmogan
Copy link
Collaborator

Responding to issue #362, looks like I just forgot to name branch to branch_name. I've tested locally that supplying an overwrite_branch to DAQRelease works as expected, e.g., I can checkout production/v4 instead of develop and generate the repos correctly.

Also, I realized there's no obvious reason to set a default value for branch_name, so it's now a required argument.

@jcfreeman2
Copy link
Collaborator

Looks good.

@jcfreeman2 jcfreeman2 merged commit ca387f6 into develop Apr 12, 2024
1 check passed
@jcfreeman2 jcfreeman2 deleted the amogan/issue362_unused_variable branch April 12, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants