-
Notifications
You must be signed in to change notification settings - Fork 101
feat(flink): implement suggestion support for table properties in CREATE TABLE #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
13374e3
feat(flink): implement suggestion support for table properties in CRE…
ekazakas 802a843
fix(suggestion): move SQL to fixtures
ekazakas 94ec619
chore(sql): add EOL
ekazakas ed7e81e
feat(flink): implement suggestion support for table properties in CRE…
ekazakas 9d5fc13
fix(suggestion): move SQL to fixtures
ekazakas 65a8760
Merge branch 'next' into next
ekazakas c51a2d8
fix(syntaxSuggestion): resolve conflicts and move tests
ekazakas c0e29a3
fix: revert old changes
ekazakas a19b3c9
fix: revert old changes
ekazakas 53c34cb
fix: merge issues
ekazakas b72fdb6
fix: unit tests
ekazakas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
SELECT * FROM aa.bb; | ||
|
||
USE | ||
USE | ||
; | ||
CREATE | ||
; | ||
SHOW | ||
; | ||
CREATE TABLE IF NOT EXISTS | ||
; | ||
SHOW | ||
|
||
CREATE TABLE tmp_table (col INT) WITH ('connector'='kafka'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.