-
Notifications
You must be signed in to change notification settings - Fork 14
Implementing formattable strings #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HastagGuigui
wants to merge
21
commits into
DPS2004:master
Choose a base branch
from
HastagGuigui:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It takes in a base string with formattable tags, the values in question, and then optionally a plural s when needed
HastagGuigui
added a commit
to HastagGuigui/rdtradingcards
that referenced
this pull request
Dec 30, 2022
formatstring() is not yet present in RDcards, i really need to finish DPS2004#50
set strings as keys at formatstring()
fix(formatstring): replace unreplaced "index"s
changes include - Changed smells for new cards - Fixed up aimeebaysr
Added a bunch of characters & changed a couple of things
added srtgoat, bodybuilder and fixed names of cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formattable strings can be used to change dynamically parts of strings depending on different parameters.
Basic usage
To use it in any commands, just call it by
formatstring()It takes two arguments as well as a third optional one for plural.For example, let's take a string that can be formatted using this function:
This will be
lang.stored_message.Then, let's also take some arguments. We can see here that we need 4 arguments (the user id, their pronoun "their", the amount of cards stored, and the card(s) stored.)
These will be in order:
"448560475987509268","his", an integer (4), and"Samurai (Rare)"Now, here's the function in action:
Isn't that great?
Why adding it?
It makes translating easier, because you don't have to have a set order for variables, and you won't need a ton of if else per language.
How do I try it out?
c!runlua print(formatstring("bogo{1s} {2}" {7, "binted"}, "s"))
If it prints out "bogos binted" in the console, it works!
TODO
hopefully this is a good enough pull request message :edegabudgetcuts: