Don't display clarification time from before/after contest #3192
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
time_before_contest
branch
from
29417ed to
34a63fe
Compare
nickygerritsen
approved these changes
Nov 10, 2025
Member
nickygerritsen
left a comment
nickygerritsen
left a comment
There was a problem hiding this comment.
I wonder if we have any cases where this would look ugly but can't think of any.
I like the idea but would wait for other opinions before merging.
Member
Author
I looked at the pages and I think it works in most locations, I disabled it for one. The question is if we do like this for Fine with waiting for some extra opinions. |
Member
I don't see any changes to .twig files? |
vmcj
force-pushed
the
time_before_contest
branch
from
34a63fe to
71c0111
Compare
It looks ugly in some cases and less professional in others where printing happened much earlier. The exact time is not relevant and could lead to discussions with teams. Originally this was only for the team interface but it does add information for the jury. It's more important to know that something happened before the contest (or after) and the interpretation of that time as knowing when it exactly happened. We still do this in case we explicit set the format such as for the countdown etc.
vmcj
force-pushed
the
time_before_contest
branch
from
71c0111 to
1b214ae
Compare
Member
Author
I was talking about and I think I removed it as it should already work. I've now added it back just to be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks ugly in some cases and less professional in others where printing happened much earlier. The exact time is not relevant and could lead to discussions with teams.
Originally this was only for the team interface but it does add information for the jury. It's more important to know that something happened before the contest (or after) and the interpretation of that time as knowing when it exactly happened.