Skip to content

When we shadow, trust the filenames and file sizes. #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

When we shadow, trust the filenames and file sizes. #3004

wants to merge 1 commit into from

Conversation

nickygerritsen
Copy link
Member

No description provided.

@nickygerritsen nickygerritsen enabled auto-merge May 25, 2025 19:15
@nickygerritsen nickygerritsen mentioned this pull request May 25, 2025
Open
@meisterT
Copy link
Member

Hmmm after seeing the issue you filed I'm no longer sure I approve... Have to think more

@nickygerritsen nickygerritsen added this pull request to the merge queue May 25, 2025
@nickygerritsen nickygerritsen removed this pull request from the merge queue due to a manual request May 25, 2025
@nickygerritsen
Copy link
Member Author

I removed it from the merge queue for now. We need to think about it maybe more, but currently we can't import these submissions and thus have differences.

Maybe we should import them as import-error, which should make them not judge in DOMjudge.

@nickygerritsen
Copy link
Member Author

In fact I like that: if one of the things from the shadow don't follow our settings, mark it as import error and don't create a judging. Wdyt?

@meisterT
Copy link
Member

That sounds indeed better and doesn't require us to change internal assumptions

@nickygerritsen
Copy link
Member Author

Let me change this PR then

@nickygerritsen nickygerritsen force-pushed the shadowing-trust-filenames-and-size branch from a34a27d to 9c9ec9f Compare May 25, 2025 20:04
@nickygerritsen nickygerritsen linked an issue May 25, 2025 that may be closed by this pull request
Make scripts work with 'illegal' filenames #3005
Open
@nickygerritsen
Copy link
Member Author

Tested this code at NAC dress and it seems to work:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make scripts work with 'illegal' filenames
2 participants
@nickygerritsen @meisterT