Keep the owner:group of the one downloading the tarball

.github/jobs/configure-checks/all.bats

@@ -10,12 +10,24 @@ cmd="apt-get"
 if [ "$distro_id" = "ID=fedora" ]; then
     cmd=dnf
 fi
+if [ "$distro_id" = "ID=arch" ]; then
+    cmd=pacman  --non-interactive
+fi
+if [ "$distro_id" = 'ID="opensuse-leap"' ]; then
+    cmd=zypper
+fi
 
 translate () {
     args="$@"
-    if [ "$distro_id" = "ID=fedora" ]; then
+    if [ "$distro_id" = 'ID="opensuse-leap"' ]; then
+        args=${args/g++/gcc-c++}
+    fi
+    if [ "$distro_id" = "ID=fedora" ] || [ "$distro_id" = 'ID="opensuse-leap"' ]; then
         args=${args/libcgroup-dev/libcgroup-devel}
     fi
+    if [ "$distro_id" = "ID=arch" ]; then
+        args=${args/libcgroup-dev/}
+    fi
     echo "$args"
 }
 
@@ -37,6 +49,9 @@ setup() {
     if [ "$distro_id" = "ID=fedora" ]; then
         repo-install httpd
     fi
+    if [ "$distro_id" = 'ID="opensuse-leap"' ]; then
+        repo-install apache2
+    fi
     repo-install gcc g++ libcgroup-dev composer
 }
 
@@ -46,16 +61,36 @@ run_configure () {
 
 repo-install () {
     args=$(translate $@)
-    ${cmd} install $args -y >/dev/null
+    if [ "$distro_id" = "ID=arch" ]; then
+        ${cmd} $args -Sy --noconfirm >/dev/null
+    else
+        ${cmd} install -y $args >/dev/null
+    fi
 }
+
 repo-remove () {
     args=$(translate $@)
-    ${cmd} remove $args -y #>/dev/null
+    if [ "$distro_id" = 'ID="opensuse-leap"' ]; then
+        ${cmd} remove -y $args >/dev/null || ret="$?"
+        if [ "$ret" -ne "104" ]; then
+            return $?
+        fi
+    else
+        ${cmd} remove -y $args #>/dev/null
+    fi
     if [ "$distro_id" != "ID=fedora" ]; then
         apt-get autoremove -y 2>/dev/null
     fi
 }
 
+run_user_stderr () {
+    su $u -c "$*" 2>&1
+}
+
+run_stderr () {
+    run "$* 2>&1"
+}
+
 @test "Default empty configure" {
     # cleanup from earlier runs
     repo-remove gcc g++ clang
@@ -111,7 +146,7 @@ compile_assertions_finished () {
 }
 
 @test "Install GNU C only" {
-    if [ "$distro_id" = "ID=fedora" ]; then
+    if [ "$distro_id" = "ID=fedora" ] || [ "$distro_id" = "ID=arch" ]; then
         # Fedora ships with a gcc with enough C++ support
         skip
     fi
@@ -418,6 +453,7 @@ compile_assertions_finished () {
   assert_line " * judgehost...........: /opt/domjudge/judgehost"
   assert_line " * runguard group......: domjudge-run"
   run make domserver
+  assert_regex "^.*cp -a vendor/nelmio/api-doc-bundle/public/\* public/bundles/nelmioapidoc.*$"
   assert_success
   run make judgehost
   assert_success
@@ -458,3 +494,84 @@ compile_assertions_finished () {
   run make judgehost
   assert_failure
 }
+
+#@test "'Make distclean' has all permissions" {
+#
+# 
+#
+#  if [ "$distro_id" = "ID=fedora" ]; then
+# 
+#
+#      # Fails as libraries are not found
+# 
+#
+#      skip
+# 
+#
+#  fi
+# 
+#
+#  setup
+# 
+#
+#  run run_configure
+# 
+#
+#  run_user_stderr make domserver
+# 
+#
+#  make install-domserver
+# 
+#
+#  run_user_stderr make distclean
+# 
+#
+#  refute_partial "cannot remove"
+# 
+#
+#  refute_partial "Permission denied"
+# 
+#
+#  assert_success
+# 
+#
+#}
+# 
+#
+#
+# 
+#
+#@test "'Make distclean' has permission errors" {
+# 
+#
+#  if [ "$distro_id" = "ID=fedora" ]; then
+# 
+#
+#      # Fails as libraries are not found
+# 
+#
+#      skip
+# 
+#
+#  fi
+# 
+#
+#  setup
+# 
+#
+#  run run_configure
+# 
+#
+#  run_stderr make install-domserver
+# 
+#
+#  run_user_stderr make distclean
+# 
+#
+#  assert_partial "cannot remove"
+# 
+#
+#  assert_partial "Permission denied"
+# 
+#
+#}

.github/jobs/configure-checks/setup_configure_image.sh

@@ -6,18 +6,19 @@ distro_id=$(grep "^ID=" /etc/os-release)
 
 # Install everything for configure and testing
 case $distro_id in
+    "ID=arch")
+        pacman -Sy --noconfirm make bats tar ;;
     "ID=fedora")
-        dnf install pkg-config make bats autoconf automake util-linux -y ;;
+        dnf install make bats -y ;;
+    'ID="opensuse-leap"')
+        zypper install -y make bats ;;
     *)
         apt-get update; apt-get full-upgrade -y
-        apt-get install pkg-config make bats autoconf -y ;;
+        apt-get install make bats -y ;;
 esac
 
-# Build the configure file
-make configure
-
 # Install extra assert statements for bots
 cp submit/assert.bash .github/jobs/configure-checks/
 
 # Run the configure tests for this usecase
-test_path="/__w/domjudge/domjudge" bats .github/jobs/configure-checks/all.bats
+test_path="/__w/domjudge/domjudge/release" bats .github/jobs/configure-checks/all.bats

.github/workflows/autoconf-check.yml

@@ -7,7 +7,93 @@ on:
       - '[0-9]+.[0-9]+'
 
 jobs:
+  build:
+    runs-on: ubuntu-latest
+    container:
+      image: domjudge/gitlabci:24.04
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v3
+      - name: Create the distribution tarball
+        run: |
+          make dist
+          cd ..
+          mv domjudge release
+          mkdir domjudge #Workdir for next steps
+          tar -cf release.tar release
+          gzip -9 release.tar
+          mv release.tar.gz domjudge/
+      - name: Upload Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          compression-level: 0
+          name: test-tarball
+          path: ${{ github.workspace }}/release.tar.gz
+
+  suse-family:
+    needs: build
+    strategy:
+      matrix:
+        version: [latest]
+        os: [opensuse/leap]
+    runs-on: ubuntu-latest
+    container:
+      image: ${{ matrix.os }}:${{ matrix.version }}
+    steps:
+      - name: Download Artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: test-tarball
+      - name: Install needed unpack tools
+        run: zypper install -y tar gzip
+      - name: Unpack the "Release" tarball
+        run: tar xvf release.tar.gz
+      - name: Setup image and run bats tests
+        working-directory: release
+        run: .github/jobs/configure-checks/setup_configure_image.sh
+
+  arch-family:
+    needs: build
+    strategy:
+      matrix:
+        version: [latest]
+        os: [archlinux]
+    runs-on: ubuntu-latest
+    container:
+      image: ${{ matrix.os }}:${{ matrix.version }}
+    steps:
+      - name: Download Artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: test-tarball
+      - name: Unpack the "Release" tarball
+        run: tar xvf release.tar.gz
+      - name: Setup image and run bats tests
+        working-directory: release
+        run: .github/jobs/configure-checks/setup_configure_image.sh
+
+  redhat-family:
+    needs: build
+    strategy:
+      matrix:
+        version: [latest]
+        os: [fedora]
+    runs-on: ubuntu-latest
+    container:
+      image: ${{ matrix.os }}:${{ matrix.version }}
+    steps:
+      - name: Download Artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: test-tarball
+      - name: Unpack the "Release" tarball
+        run: tar xvf release.tar.gz
+      - name: Setup image and run bats tests
+        working-directory: release
+        run: .github/jobs/configure-checks/setup_configure_image.sh
+
   debian-family:
+    needs: build
     strategy:
       matrix:
         version: [jammy, focal, rolling]
@@ -28,8 +114,21 @@ jobs:
     container:
       image: ${{ matrix.os }}:${{ matrix.version }}
     steps:
-      - name: Install git so we get the .github directory
-        run: apt-get update; apt-get install -y git
-      - uses: actions/checkout@v4
+      - name: Download Artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: test-tarball
+      - name: Unpack the "Release" tarball
+        run: |
+          ls -atrl
+          tar xvf release.tar.gz
       - name: Setup image and run bats tests
+        working-directory: release
         run: .github/jobs/configure-checks/setup_configure_image.sh
+
+#
+## Copy the fedora stuff here and use:
+## if: github.event_name != 'merge_group' on the job level
+##name: Build and Trigger Workflows
+### Either just filter the fedora stuff in onther build step (and run on main but skip) or trigger 2 workflows. I don't work enough with GHA to see which one I prefer for now.
+##

.github/workflows/chroot-checks.yml

@@ -1,30 +0,0 @@
-name: Chroot checks
-on:
-  push:
-  pull_request:
-    branches:
-      - main
-      - '[0-9]+.[0-9]+'
-
-jobs:
-  check-chroot-arch:
-    runs-on: ubuntu-24.04
-    container:
-      image: domjudge/gitlabci:24.04
-      options: --privileged --cgroupns=host --init
-    strategy:
-      matrix:
-        arch: [amd64, default]
-    steps:
-      - name: Checkout current code
-        uses: actions/checkout@v4
-      - name: Install DOMjudge
-        run: |
-          .github/jobs/chroot_checks.sh ${{ matrix.arch }}
-      - name: Upload all logs/artifacts
-        if: ${{ !cancelled() }}
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ matrix.arch }}-logs
-          path: |
-            /tmp/artifacts