[REFACTOR] saveMember 리팩터링, repository에서 명시하지 않아도 되는 메서드 삭제

howoldareu_clone/build.gradle

@@ -28,6 +28,8 @@ dependencies {
 	runtimeOnly 'com.mysql:mysql-connector-j'
 	annotationProcessor 'org.projectlombok:lombok'
 	testImplementation 'org.springframework.boot:spring-boot-starter-test'
+    testImplementation 'org.springframework.restdocs:spring-restdocs-mockmvc'
+    testImplementation 'org.springframework.restdocs:spring-restdocs-asciidoctor'
 }
 
 tasks.named('test') {

howoldareu_clone/src/main/java/com/sopt/Server/controller/MemberController.java

@@ -9,16 +9,16 @@
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RestController;
 
+import static com.sopt.Server.exception.Success.CREATE_MEMBER_SUCCESS;
+
 @RestController
 @RequiredArgsConstructor
 public class MemberController {
-
+    
     private final MemberService memberService;
 
     @PostMapping("/member")
     public ApiResponse<MemberGetResponse> saveMember(@RequestBody MemberPostRequest request) {
-
-        ApiResponse<MemberGetResponse> response = memberService.saveMember(request.nickName(), request.age());
-        return response;
+        return ApiResponse.success(CREATE_MEMBER_SUCCESS, memberService.saveMember(request));
     }
 }

howoldareu_clone/src/main/java/com/sopt/Server/domain/Answer.java

@@ -14,7 +14,7 @@ public class Answer {
     @Id @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long answerId;
 
-    @ManyToOne
+    @ManyToOne(fetch = FetchType.LAZY)
     private Question question;
 
     private boolean answerType;

howoldareu_clone/src/main/java/com/sopt/Server/repository/MemberJpaRepository.java

@@ -1,10 +1,16 @@
 package com.sopt.Server.repository;
 
 import com.sopt.Server.domain.Member;
+import jakarta.persistence.EntityNotFoundException;
 import org.springframework.data.jpa.repository.JpaRepository;
 
 import java.util.Optional;
 
 public interface MemberJpaRepository extends JpaRepository<Member, Long> {
     Optional<Member> findByName(String name);
+    default Member findByNameOrThrow(String name) {
+        return findByName(name)
+                .orElseThrow(() ->
+                        new EntityNotFoundException("해당 이름의 회원이 존재하지 않습니다."));
+    }
 }

howoldareu_clone/src/main/java/com/sopt/Server/repository/QuestionJpaRepository.java

@@ -7,6 +7,4 @@
 import java.util.Optional;
 
 public interface QuestionJpaRepository extends JpaRepository<Question, Long>{
-    List<Question> findAll();
-    Optional<Question> findById(Long id);
 }

howoldareu_clone/src/main/java/com/sopt/Server/repository/ResultJpaRepository.java

@@ -6,7 +6,5 @@
 import java.util.List;
 
 public interface ResultJpaRepository extends JpaRepository<Result, Long>{
-    Result save(Result result);
-
     List<Result> findAllByMemberIdOrderByIdDesc(Long memberId);
 }

howoldareu_clone/src/main/java/com/sopt/Server/service/MemberService.java

@@ -1,16 +1,14 @@
 package com.sopt.Server.service;
 
-import com.sopt.Server.common.ApiResponse;
+import com.sopt.Server.controller.request.MemberPostRequest;
 import com.sopt.Server.controller.response.MemberGetResponse;
 import com.sopt.Server.domain.Member;
-import com.sopt.Server.exception.Success;
 import com.sopt.Server.repository.MemberJpaRepository;
+import jakarta.persistence.EntityNotFoundException;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-import java.util.Optional;
-
 @Service
 @RequiredArgsConstructor
 @Transactional(readOnly = true)
@@ -19,14 +17,17 @@ public class MemberService {
     private final MemberJpaRepository memberJpaRepository;
 
     @Transactional
-    public ApiResponse<MemberGetResponse> saveMember(String nickName, int age) {
-        Member newMember = Member.builder().name(nickName).realAge(age).build();
-        Member member = memberJpaRepository.findByName(nickName).orElse(null);//null이면
-        if(member != null)//있다면
-            return ApiResponse.success(Success.GET_MEMBER_SUCCESS, MemberGetResponse.of(member));
-        else {
+    public MemberGetResponse saveMember(MemberPostRequest request) {
+        try {
+            Member member = memberJpaRepository.findByNameOrThrow(request.nickName());
+            return MemberGetResponse.of(member);
+        } catch (EntityNotFoundException e) {
+            Member newMember = Member.builder()
+                    .name(request.nickName())
+                    .realAge(request.age())
+                    .build();
             memberJpaRepository.save(newMember);
+            return MemberGetResponse.of(newMember);
         }
-        return ApiResponse.success(Success.CREATE_MEMBER_SUCCESS, MemberGetResponse.of(newMember));
     }
 }