Repository navigation
refactor: tlim_int_refactor - #5003
Merged
Merged
Conversation
TomOnTime
added a commit
that referenced
this pull request
Oct 15, 2026
## Summary Convert the remaining integration record fixtures with representable zone-format data to `tr()`. This covers TXT quoting and chunk boundaries, HTTPS/SVCB parameters, LOC, OPENPGPKEY, provider pseudo types, and record metadata. Remove the constructors made unused by these conversions and enable the existing `withMeta` option. Keep four fixtures on typed constructors where `tr()` currently changes the behavior under test: Unicode CNAME target normalization, a relative ALIAS target, Cloudflare single-redirect expression escaping, and empty MIKROTIK_NXDOMAIN RDATA. Each retained helper has a comment explaining the parser difference. Unicode CNAME normalization will be addressed in a separate production-code PR. ## Validation - Compared complete `makeTests()` fixture structures with an independent copy of the pre-change constructors across 16 combinations of domain, site, and Cloudflare feature flags; all matched. - `go test ./...` passed before rebasing onto the merged #5003 branch; `go test ./integrationTest` passed after rebasing onto current `main`. - `git diff --check origin/main...HEAD` passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 566 record constructors across 18 standard DNS types with
tr()calls containing zone-format RDATA. Convert 11 TTL wrappers to the existingwithTTL()option, update the corresponding commented fixture steps, and remove 16 unused helpers.Leave TXT, LOC, HTTPS/SVCB, OPENPGPKEY, provider-specific helpers, and two Unicode CNAME targets for follow-up. The equivalence check found that the old CNAME constructor converts Unicode targets to punycode while
tr()currently preserves Unicode, so those two cases retain the old helper.Validation:
go test ./...passes.reflect.DeepEqualto compare the original and refactoredmakeTests()results, including all group filters, test expectations, record fields/RDATA, metadata, and unmanaged settings. All 16 combinations passed: four domain names (ordinary, nested, punycode, Unicode), two site settings, and option flags enabled/disabled.