refactor: Reduce unused "metadata" parameters in provider initializations

commands/provider_syntax_test.go

@@ -227,9 +227,9 @@ func TestProviderConversionGuide(t *testing.T) {
 	guide, err := os.ReadFile("../documentation/getting-started/converting-dnsconfig.md")
 	require.NoError(t, err)
 	examples := regexp.MustCompile("(?s)```javascript\\n(.*?)```").FindAllStringSubmatch(string(guide), -1)
-	require.Len(t, examples, 4, "two complete before/after pairs")
+	require.Len(t, examples, 2, "one complete before/after pair")
 	credsPath := filepath.Join(t.TempDir(), "creds.json")
-	require.NoError(t, os.WriteFile(credsPath, []byte(`{"dnsimple":{"TYPE":"DNSIMPLE"}}`), 0o600))
+	require.NoError(t, os.WriteFile(credsPath, []byte(`{"gandi_main":{"TYPE":"GANDI_V5"}}`), 0o600))
 	creds, err := credsfile.LoadProviderConfigs(credsPath)
 	require.NoError(t, err)
 	for i := 0; i < len(examples); i += 2 {

providers/akamaiedgedns/akamaiEdgeDnsProvider.go

@@ -119,7 +119,7 @@ func init() {
 }
 
 // DnsServiceProvider.
-func newEdgeDNSDSP(config map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newEdgeDNSDSP(config map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	clientSecret := config["client_secret"]
 	host := config["host"]
 	accessToken := config["access_token"]

providers/alidns/aliDnsProvider.go

@@ -79,7 +79,7 @@ type domainVersionInfo struct {
 	maxTTL      uint32
 }
 
-func newAliDNSDsp(config map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newAliDNSDsp(config map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	accessKeyID := config["access_key_id"]
 	if accessKeyID == "" {
 		return nil, errors.New("creds.json: access_key_id must not be empty")

providers/cloudns/cloudnsProvider.go

@@ -37,7 +37,7 @@ func newCloudns(m map[string]string) (*cloudnsProvider, error) {
 	return c, nil
 }
 
-func newDsp(conf map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newDsp(conf map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	return newCloudns(conf)
 }
 

providers/desec/desecProvider.go

@@ -20,7 +20,7 @@ Info required in `creds.json`:
 */
 
 // NewDeSec creates the provider.
-func NewDeSec(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewDeSec(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	c := &desecProvider{}
 	c.token = strings.TrimSpace(m["auth-token"])
 	if c.token == "" {

providers/digitalocean/digitaloceanProvider.go

@@ -47,7 +47,7 @@ var defaultNameServerNames = []string{
 const perPageSize = 100
 
 // NewDo creates a DO-specific DNS provider.
-func NewDo(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewDo(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["token"] == "" {
 		return nil, errors.New("no DigitalOcean token provided")
 	}

providers/domainnameshop/domainnameshopProvider.go

@@ -60,7 +60,7 @@ func init() {
 }
 
 // newDomainNameShopProvider creates a Domainnameshop specific DNS provider.
-func newDomainNameShopProvider(conf map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newDomainNameShopProvider(conf map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if conf["token"] == "" {
 		return nil, errors.New("no Domainnameshop token provided")
 	} else if conf["secret"] == "" {

providers/dynu/dynuProvider.go

@@ -58,7 +58,7 @@ func init() {
 }
 
 // New creates a Dynu provider from credentials.
-func New(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func New(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	apiKey := m["api_key"]
 	if apiKey == "" {
 		return nil, errors.New("missing Dynu API key")

providers/gcore/gcoreProvider.go

@@ -32,7 +32,7 @@ func (c *gcoreProvider) SetConversionObserver(observer providers.ConversionObser
 }
 
 // NewGCore creates the provider.
-func NewGCore(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewGCore(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["api-key"] == "" {
 		return nil, errors.New("missing G-Core API key")
 	}

providers/gidinet/gidinetProvider.go

@@ -107,7 +107,7 @@ func newRegistrar(m map[string]string) (providers.Registrar, error) {
 }
 
 // NewGidinet creates a new Gidinet DNS provider.
-func NewGidinet(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewGidinet(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["username"] == "" {
 		return nil, errors.New("missing Gidinet username")
 	}

providers/huaweicloud/huaweicloudProvider.go

@@ -50,7 +50,7 @@ const (
 )
 
 // newHuaweicloud creates the provider.
-func newHuaweicloud(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newHuaweicloud(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	auth, err := basic.NewCredentialsBuilder().
 		WithAk(m["KeyId"]).
 		WithSk(m["SecretKey"]).

providers/infoblox/infobloxProvider.go

@@ -36,7 +36,7 @@ type infobloxProvider struct {
 	api *infobloxAPI
 }
 
-func newInfobloxDsp(conf map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newInfobloxDsp(conf map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	return newInfoblox(conf)
 }
 

providers/inwx/inwxProvider.go

@@ -195,7 +195,7 @@ func newInwxReg(m map[string]string) (providers.Registrar, error) {
 }
 
 // new InwxDsp is called to initialize the INWX domain service provider.
-func newInwxDsp(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newInwxDsp(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	return newInwx(m)
 }
 

providers/joker/jokerProvider.go

@@ -89,7 +89,7 @@ type jokerProvider struct {
 }
 
 // newJoker creates a new Joker DMAPI provider.
-func newJoker(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newJoker(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	api := &jokerProvider{
 		apiURL:     "https://dmapi.joker.com/request/",
 		httpClient: &http.Client{Timeout: 30 * time.Second},

providers/linode/linodeProvider.go

@@ -62,7 +62,7 @@ var defaultNameServerNames = []string{
 }
 
 // NewLinode creates the provider.
-func NewLinode(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewLinode(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["token"] == "" {
 		return nil, errors.New("missing Linode token")
 	}

providers/luadns/luadnsProvider.go

@@ -90,7 +90,7 @@ func (l *luadnsProvider) SetConversionObserver(observer providers.ConversionObse
 }
 
 // NewLuaDNS creates the provider.
-func NewLuaDNS(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewLuaDNS(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["email"] == "" || m["apikey"] == "" {
 		return nil, errors.New("missing LuaDNS email or apikey")
 	}

providers/mythicbeasts/mythicbeastsProvider.go

@@ -81,7 +81,7 @@ func init() {
 	})
 }
 
-func newDsp(conf map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newDsp(conf map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if conf["keyID"] == "" {
 		return nil, errors.New("missing Mythic Beasts auth keyID")
 	}

providers/netbird/netbirdProvider.go

@@ -45,7 +45,7 @@ type netbirdProvider struct {
 }
 
 // NewNetbird creates a NetBird-specific DNS provider.
-func NewNetbird(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewNetbird(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["token"] == "" {
 		return nil, errors.New("no NetBird token provided")
 	}

providers/opensrs/opensrsProvider.go

@@ -122,7 +122,7 @@ func newReg(conf map[string]string) (providers.Registrar, error) {
 	return newProvider(conf, nil)
 }
 
-func newProvider(m map[string]string, metadata json.RawMessage) (*opensrsProvider, error) {
+func newProvider(m map[string]string, _ json.RawMessage) (*opensrsProvider, error) {
 	api := &opensrsProvider{}
 	api.APIKey = m["apikey"]
 

providers/packetframe/packetframeProvider.go

@@ -28,7 +28,7 @@ func (api *packetframeProvider) SetConversionObserver(observer providers.Convers
 }
 
 // newPacketframe creates the provider.
-func newPacketframe(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newPacketframe(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["token"] == "" {
 		return nil, errors.New("missing Packetframe token")
 	}

providers/tencentdns/tencentdnsProvider.go

@@ -86,7 +86,7 @@ type tencentdnsProvider struct {
 	client *tencentCloudClient
 }
 
-func newTencentDNSDsp(config map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func newTencentDNSDsp(config map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	return newTencentDNS(config)
 }
 

providers/transip/transipProvider.go

@@ -68,7 +68,7 @@ var features = providers.DocumentationNotes{
 }
 
 // NewTransip creates a new TransIP provider.
-func NewTransip(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewTransip(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	if m["AccessToken"] == "" && m["PrivateKey"] == "" {
 		return nil, errors.New("no TransIP AccessToken or PrivateKey provided")
 	}

providers/vultr/vultrProvider.go

@@ -66,7 +66,7 @@ var defaultNS = []string{
 }
 
 // NewProvider initializes a Vultr DNSServiceProvider.
-func NewProvider(m map[string]string, metadata json.RawMessage) (providers.DNSServiceProvider, error) {
+func NewProvider(m map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
 	token := m["token"]
 	if token == "" {
 		return nil, errors.New("missing Vultr API token")