Repository navigation
feat(p/AZURE_PRIVATE_DNS): Add OIDC support / support same auth methods as AZURE_DNS - #4929
Merged
Merged
Conversation
Closed
6 tasks done
cafferata
reviewed
Sep 24, 2026
cafferata
left a comment
Member
There was a problem hiding this comment.
Thanks @TomOnTime. I compared the AZURE_PRIVATE_DNS preview with the AZURE_DNS page side by side, and apart from the naming the sections now match. I left one inline comment.
The other way around, the AZURE_DNS page has drifted a bit from the code this pull request ports: its Caveats still say "The ResourceGroup is case sensitive." although AZURE_DNS lowercases it as well, its Activation section only mentions client credentials, and there's a stray + before the second "You can also use environment variables:". Happy to pick that up in a separate pull request so this one stays focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Azure's "Azure Private DNS" service supports the same authentication methods as Azure's "Azure DNS" service. However the code for DNSControl's
AZURE_PRIVATE_DNSprovider doesn't support the same methods. That is,AZURE_PRIVATE_DNSis missing support forResolution
AZURE_DNStoAZURE_PRIVATE_DNSso both providers support the same auth methods: DefaultAzureCredential (default fallback), Client ID + Secret (backward compatible), and OIDC interactive browser loginAZURE_DNSbehavior)fetchRecordSets()to useerrors.Asinstead of type assertion for proper wrapped error handlingfmt.Errorffor better diagnosticsCC @matthewmgamble I've ported your changes to v5. Please confirm this works as I don't have access.
CC @cafferata Please review the docs. They should be nearly identical to AZURE_DNS. I ported over the changes from #4847