Repository navigation
fix: fix an unlikely JSON injection security vulnerability - #4928
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
An MX record with the target
mx1.example.com"), A("attacker-controlled", "203.0.113.66will forcednscontrol get-zone --format jsto generate adnsconfig.jsfile with an extraArecord.Resolution
JSON-quote all fields.
Risk
Low.
dnscontrol previewwould highlight the change.dnscontrol pushwould undo their change.dnscontrol get-zone --format jsyou are forced to edit the output (it isn't perfect, just "a good first draft") and you'd probably notice this situation, especially if you rundnscontrol fmtAlas, stranger attacks have happened. Therefore, we're fixing this.
CC @cafferata who did the work, I'm just merging the PR.