Skip to content

chore: unify all auditrecords.go files #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomOnTime merged 2 commits into from
Sep 22, 2026
Merged

chore: unify all auditrecords.go files #4924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c924dc
chore: Make all auditrecords.go similar
TomOnTime Sep 22, 2026
f05d3ec
Merge branch 'main' into tlim_a
TomOnTime Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions providers/exoscale/auditrecords.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ import (
// AuditRecords returns a list of errors corresponding to the records that aren't supported by this provider.
// If all records are supported, an empty list is returned.
func AuditRecords(records models.Records) []error {
auditor := rejectif.Auditor{}
a := rejectif.Auditor{}

auditor.Add("CAA", rejectif.CaaTargetContainsWhitespace) // Last verified 2022-07-11
a.Add("CAA", rejectif.CaaTargetContainsWhitespace) // Last verified 2022-07-11

auditor.Add("MX", rejectif.MxNull) // Last verified 2022-07-11
a.Add("MX", rejectif.MxNull) // Last verified 2022-07-11

auditor.Add("PTR", func(rc *models.RecordConfig) error {
a.Add("PTR", func(rc *models.RecordConfig) error {
return errors.New("PTR records are not supported by the Exoscale provider")
})

auditor.Add("SRV", rejectif.SrvHasNullTarget) // Last verified 2020-12-28
a.Add("SRV", rejectif.SrvHasNullTarget) // Last verified 2020-12-28

auditor.Add("TXT", rejectif.TxtHasUnpairedBackslash) // Last verified 2026-05-04
auditor.Add("TXT", rejectif.TxtHasDoubleQuotes) // Last verified 2026-05-04
auditor.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2026-05-04
a.Add("TXT", rejectif.TxtHasUnpairedBackslash) // Last verified 2026-05-04
a.Add("TXT", rejectif.TxtHasDoubleQuotes) // Last verified 2026-05-04
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2026-05-04

return auditor.Audit(records)
return a.Audit(records)
}
8 changes: 4 additions & 4 deletions providers/realtimeregister/auditrecords.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ import (
// that aren't supported by this provider. If all records are
// supported, an empty list is returned.
func AuditRecords(records models.Records) []error {
auditor := rejectif.Auditor{}
a := rejectif.Auditor{}

auditor.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2024-01-03
a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2024-01-03

auditor.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2024-01-03
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2024-01-03

return auditor.Audit(records)
return a.Audit(records)
}
Loading