Repository navigation
chore(deps): update commitlint to v21 - #4900
Merged
Merged
Conversation
- Bump `@commitlint/cli` and `@commitlint/config-conventional` to `^21.2.2` in `package.json` and `package-lock.json`, replacing the deprecated `git-raw-commits` with `@conventional-changelog/git-client`. - Add `"name": "dnscontrol"` to `package.json`, so `npm install` no longer derives the name in `package-lock.json` from the checkout directory.
cafferata
force-pushed
the
chore/commitlint-v21
branch
from
September 19, 2026 09:33
ff633ee to
5db0704
Compare
TomOnTime
approved these changes
Sep 19, 2026
Collaborator
|
@cafferata Yes, please open a PR to add npm to .github/dependabot.yml |
This was referenced Sep 19, 2026
TomOnTime
added a commit
that referenced
this pull request
Sep 19, 2026
Follow-up to #4900. While updating commitlint there, I noticed that the deprecated `git-raw-commits` dependency went unnoticed because `.github/dependabot.yml` covers GitHub Actions, Go modules and Docker, but not npm. As agreed in #4900 (comment), this adds npm. This GitHub pull request adds an `npm` entry for the root `package.json`, in the same style as the `gomod` and `docker` entries: a monthly schedule with a 7-day cooldown. Dependabot will then also propose updates for `prettier`, which is pinned to `3.9.5`, and `@umbrelladocs/linkspector`. If `prettier` should stay pinned, an `ignore` for it can be added here. ## AI-attributie Assisted-by: Claude Code:claude-opus-5 --------- Co-authored-by: Tom Limoncelli <tal@whatexit.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm installwarns thatgit-raw-commits@4.0.0is deprecated and no longer maintained. It comes in through@commitlint/readfrom@commitlint/cli19, which thePR: Commitlintcheck from #4873 installs on every pull request. Commitlint 21 replaced it with@conventional-changelog/git-client, so this bumps@commitlint/cliand@commitlint/config-conventionalto^21.2.2.The
package-lock.jsonchanges stay within the commitlint dependency tree.prettierand@umbrelladocs/linkspectorare untouched, andnpm installno longer prints the warning. Commitlint 21 requires Node>=22.12.0, and the workflow already usesnode-version: latest.It also adds
"name": "dnscontrol"topackage.json. Without it,npm installwrites the name of the checkout directory intopackage-lock.json, so running it from a worktree or a clone with a different directory name changes the lockfile.I ran the same titles through
commitlint.config.jswith version 19 and 21 and got the same results:fix(p/ROUTE53): correct TTL rounding,feat(p/BIND)!: drop something,chore(deps): update dependencies,BREAKING CHANGE: drop v3anddocs: add requested provider Sav.com (#3633).fix(p/ROUTE53): Fix TTL,DOCS: Fixed tableandfix(bad scope): x.The
^19.6.1range came in with #4873; I found no discussion about staying on 19, but let me know if there was a reason.This went unnoticed because
.github/dependabot.ymlcovers GitHub Actions, Go modules and Docker, but not npm. A suggestion, not part of this pull request: add annpmentry in the same style asgomod. That would also propose updates forprettier, which is pinned to3.9.5, and@umbrelladocs/linkspector, so it may need anignoreforprettier. Happy to open that separately if you want it.AI-attributie
Assisted-by: Claude Code:claude-opus-5