Repository navigation
docs: fix typos and a broken anchor in the README - #4898
Merged
Merged
Conversation
- Write "GitHub" instead of "Github" in the GitHub Actions section.
- Add the missing semicolon after `NewDnsProvider("r53_main")` in the example.
- Update the date in the "Deprecation warnings" heading to 2026-08-17, when the REV() warning was rewritten.
- Link the installation instructions to `#id-1.-install-the-software`, the anchor GitBook generates for that heading.
Refs DNSControl#4764
Refs DNSControl#4774
Member
Author
|
The README isn't part of GitBook, so here is the rendered README with the fixes: |
TomOnTime
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes in
README.md. #4764 introduced "The official Github Action", which now reads "GitHub". #4774 renamed the provider variable in the example toDSP_ROUTE53but dropped the trailing semicolon that the line above it has, so this adds it back. #4774 also rewrote the REV() deprecation warning without updating the date in the "Deprecation warnings (updated 2025-11-21)" heading, which now uses the merge date of #4774, 2026-08-17. While here, the "official instructions" link pointed to#1-install-the-software, an anchor that GitBook doesn't generate: GitBook uses#id-1.-install-the-softwarefor that heading, so the link now jumps to the installation section on https://docs.dnscontrol.org/getting-started/getting-started instead of the top of the page. That anchor dates back to #1788.AI-attributie
Assisted-by: Claude Code:claude-opus-5