Repository navigation
fix(IP): The IP() function breaks for 128/8 and higher - #4827
Merged
Merged
Conversation
Collaborator
Author
|
CC @mindsolve for visibility. |
This was referenced Sep 19, 2026
TomOnTime
added a commit
that referenced
this pull request
Sep 19, 2026
…ple (#4904) Follow-up to #4827. While going through the bug fix pull requests, I noticed that the new "Debug `helpers.js`" section in `documentation/advanced-features/debugging-with-dlv.md` reads `helpers.js` from `/Users/tlimoncelli/gitthings/dnscontrol/pkg/js/helpers.js`, a path that only exists on one machine. Its two code blocks also have no language, unlike the other blocks on the page, and the second one starts with a `$` prompt, so copying it doesn't work as is. This GitHub pull request changes the path to `pkg/js/helpers.js`, notes that the command runs from the root of the repository, marks both blocks as `shell` and removes the `$` prompt. I ran the updated command from the repository root and it prints `2276849648` for `IP('135.181.247.240')`. ## AI-attributie Assisted-by: Claude Code:claude-opus-5 Co-authored-by: Tom Limoncelli <tal@whatexit.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4825
IP(foo) doesn't work properly if "foo" is an IP address 128.0.0.0/8 and higher. That is, if the first octet has the high bit set.
IP("135.181.247.240")produces 127.255.255.255