Repository navigation
REFACTOR: Cleanups - #4810
Closed
TomOnTime wants to merge 284 commits into
Closed
REFACTOR: Cleanups#4810TomOnTime wants to merge 284 commits into
TomOnTime wants to merge 284 commits into
Conversation
This surfaced many bugs, which are now fixed. --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com>
…document sandbox testing (#4469) Fixes three DNS Made Easy provider bugs surfaced by the integration suite, plus docs for sandbox/integration testing. Fixes: - TXT values ≥256 bytes: send a single unchunked quoted value (EncodeSingle) instead of RFC1035 chunks, which DME stores with a literal joining space and never round-trips → perpetual spurious MODIFY. - ALIAS records: move the ALIAS→ANAME rename into the write serializer instead of mutating desired records pre-diff, so the diff compares ALIAS vs ALIAS and converges (previously looped DELETE ALIAS + CREATE ANAME). - ALIAS-to-nonfqdn integration test: exclude DNSMADEEASY, since DME validates ANAME target resolvability at create time and an unpublished in-zone target can't resolve. Docs: - Document the sandbox environment (control panel, credentials, `sandbox` creds key), add an integration-testing section with command and raised timeout, and clarify DNSMADEEASY_DEBUG_HTTP usage. Verified against the DME sandbox: full integration suite passes. **Not tested in production since I am not using DNS Made Easy anymore.** --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* helpers.js: Modernize ALIAS, AKAMAICDN, AKAMAITLC, AZURE_ALIAS * helpers.js: remove old comments Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com>
…inernally (#4479) * REFACTOR: Modernize GCLOUD. New TXT type handling maintains segments * New files: bin/is_modern.sh models/t_txt_test.go * Fix GetTargetJS() test * fixup! * use reflect instead of %T * fix init test output * fix test fixtures * tidy --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com>
* ROUTE53: Modernize * Add comment * remove comment --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com>
* REFACTOR: Modernize GCLOUD. New TXT type handling maintains segments * New files: bin/is_modern.sh models/t_txt_test.go * Fix GetTargetJS() test * fixup! * use reflect instead of %T * fix init test output * fix test fixtures * tidy * CLOUDFLAREAPI: Reduce use of legacy functions * Update comments --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com>
* REFACTOR: Modernize GCLOUD. New TXT type handling maintains segments * New files: bin/is_modern.sh models/t_txt_test.go * Fix GetTargetJS() test * fix init test output --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com>
* REFACTOR: Move more verbs to rawrecordBuilder() * Linting * fmt * CHORE: Fix GoReleaser to skip release candidates * NETBIRD: Add apiurl creds argument (#4486) NETBIRD: add apiurl creds parameter Co-authored-by: Tom Limoncelli <tal@whatexit.org> * CHORE: Update dependencies * CHORE: generate-all.sh * rdata.go lint * generate --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com> Co-authored-by: Gwilherm Folliot <gwilherm55fo@gmail.com>
NETBIRD: add apiurl creds parameter Co-authored-by: Tom Limoncelli <tal@whatexit.org>
* CHORE: Fix GoReleaser to skip release candidates * CHORE: Update dependencies * CHORE: generate-all.sh * Fix setup-node * new file: is_modern.sh
* Modernize Azure DNS record conversion * change ptr to new * AZURE_DNS now supports null TXT ans MX --------- Co-authored-by: Tom Limoncelli <tlimoncelli@coreweave.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.