Move local_used_cert_chain_slot_id to session_info
#3423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Dec 14, 2025
Comment on lines
2037
to
-2038
| spdm_context->connection_info.peer_used_cert_chain_slot_id = 0xFF; | ||
| spdm_context->connection_info.local_used_cert_chain_slot_id = 0xFF; |
Member
There was a problem hiding this comment.
Question: how about peer_used_cert_chain_slot_id ?
should we remove it as well?
Contributor
Author
There was a problem hiding this comment.
That can be used both inside and outside of a session, so it will stay inside connection_info. I will add it to session_info in a later pull request.
jyao1
reviewed
Dec 14, 2025
| spdm_key_update_request_t last_key_update_request; | ||
| void *secured_message_context; | ||
| /* Only present in session info as it is currently only used within a secure session. */ | ||
| uint8_t local_used_cert_chain_slot_id; |
Member
There was a problem hiding this comment.
should we remove local_used_cert_chain_slot_id from libspdm_connection_info_t ?
Contributor
Author
There was a problem hiding this comment.
Yes. Thanks for catching that.
steven-bellock
force-pushed
the
fix-3405
branch
2 times, most recently
from
4874109 to
f324ca4
Compare
steven-bellock
commented
Dec 17, 2025
| * @retval false Local used certificate chain data without spdm_cert_chain_t header is not found. | ||
| **/ | ||
| bool libspdm_get_local_cert_chain_data(void *spdm_context, | ||
| uint8_t slot_id, |
Contributor
Author
There was a problem hiding this comment.
libspdm_get_local_cert_chain_data is an unused function, so I am also fine if the entire function is removed.
Fix DMTF#3405 and move local_used_cert_chain_slot_id from connection_info to session_info. Signed-off-by: Steven Bellock <[email protected]>
steven-bellock
force-pushed
the
fix-3405
branch
from
f324ca4 to
2225b82
Compare
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3405 and move
local_used_cert_chain_slot_idfromconnection_infotosession_info.