Open
Conversation
Contributor
tobiasreischl
commented
Feb 18, 2026
tobiasreischl
commented
> Changed from Medium.* to SI.* > keep SI.PressureDifference > SI.Pressure -> SI.AbsolutePressure only for p, not for r > Modelica.Units.SI. changed to SI. > IMPORTANT: Media not changed (for now)
tobiasreischl
requested review from
CorentinLepais,
Nicsda,
RaphaelGebhart and
nieweber
|
|
||
| protected | ||
| SI.Pressure p_env "Environmental pressure"; | ||
| SI.AbsolutePressure p_env "Environmental pressure"; |
Collaborator
There was a problem hiding this comment.
Keep SI.AbsolutePressure. Do not change to Medium.AbsolutePressure.
| parameter Boolean pEnvFromInput = false "=true, if environmental pressure input connector is enabled" | ||
| annotation(Dialog(group="Environmental pressure"),Evaluate=true, HideResult=true, choices(checkBox=true)); | ||
| parameter SI.Pressure p_env_par=1e5 "Environmental pressure set value" | ||
| parameter SI.AbsolutePressure p_env_par=1e5 "Environmental pressure set value" |
Collaborator
There was a problem hiding this comment.
Do not change to Medium.AbsolutePressure.
|
|
||
| protected | ||
| SI.Pressure p_env "Environmental pressure"; | ||
| SI.AbsolutePressure p_env "Environmental pressure"; |
Collaborator
There was a problem hiding this comment.
Do not change to Medium.AbsolutePressure.
RaphaelGebhart
requested changes
Feb 24, 2026
Collaborator
|
The requested changes always refer to the last line of the preview.
|
| Medium.AbsolutePressure staticHeadOutlets_Pa_relative[M_outlets] "relative pressure to liquid surface, 0 if above surface"; | ||
| SI.Length staticHeadInlets[N_inlets] "distance perpendicular to liquid surface, 0 if above surface"; | ||
| SI.Length staticHeadOutlets[M_outlets] "distance perpendicular to liquid surface, 0 if above surface"; | ||
| SI.AbsolutePressure staticHeadInlets_Pa_relative[N_inlets] "relative pressure to liquid surface, 0 if above surface"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure staticHeadInlets_Pa_relative[N_inlets] "relative pressure to liquid surface, 0 if above surface"; | |
| SI.Pressure staticHeadInlets_Pa_relative[N_inlets] "relative pressure to liquid surface, 0 if above surface"; |
| SI.Length staticHeadInlets[N_inlets] "distance perpendicular to liquid surface, 0 if above surface"; | ||
| SI.Length staticHeadOutlets[M_outlets] "distance perpendicular to liquid surface, 0 if above surface"; | ||
| SI.AbsolutePressure staticHeadInlets_Pa_relative[N_inlets] "relative pressure to liquid surface, 0 if above surface"; | ||
| SI.AbsolutePressure staticHeadOutlets_Pa_relative[M_outlets] "relative pressure to liquid surface, 0 if above surface"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure staticHeadOutlets_Pa_relative[M_outlets] "relative pressure to liquid surface, 0 if above surface"; | |
| SI.Pressure staticHeadOutlets_Pa_relative[M_outlets] "relative pressure to liquid surface, 0 if above surface"; |
Comment on lines
+100
to
+101
| SI.SpecificEnthalpy | ||
| h_in[N_inlets]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.SpecificEnthalpy | |
| h_in[N_inlets]; | |
| SI.SpecificEnthalpy h_in[N_inlets]; |
Comment on lines
+105
to
+106
| SI.SpecificEnthalpy | ||
| h_out[M_outlets]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.SpecificEnthalpy | |
| h_out[M_outlets]; | |
| SI.SpecificEnthalpy h_out[M_outlets]; |
Comment on lines
+111
to
+112
| SI.DerDensityByPressure | ||
| density_derp_h=(V_ref*medium.d)/(V*K) "Partial derivative of density by pressure"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.DerDensityByPressure | |
| density_derp_h=(V_ref*medium.d)/(V*K) "Partial derivative of density by pressure"; | |
| SI.DerDensityByPressure density_derp_h=(V_ref*medium.d)/(V*K) "Partial derivative of density by pressure"; |
Comment on lines
+118
to
+119
| SI.Temperature | ||
| T_heatPort; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.Temperature | |
| T_heatPort; | |
| SI.Temperature T_heatPort; |
|
|
||
| Real u(unit="1") "Actuation input for flow calculation"; | ||
| parameter Modelica.Units.SI.Pressure dp_ref=1e5 | ||
| parameter SI.Pressure dp_ref=1e5 |
Collaborator
There was a problem hiding this comment.
Suggested change
| parameter SI.Pressure dp_ref=1e5 | |
| parameter SI.AbsolutePressure dp_ref=1e5 |
| Real friction_factor(unit="1"); | ||
| SI.Pressure pressureLossLaminar "Laminar pressure loss"; | ||
| SI.Pressure pressureLossTurbulent "Turbulent pressure loss"; | ||
| SI.AbsolutePressure pressureLossLaminar "Laminar pressure loss"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure pressureLossLaminar "Laminar pressure loss"; | |
| SI.PressureDifference pressureLossLaminar "Laminar pressure loss"; |
| SI.Pressure pressureLossLaminar "Laminar pressure loss"; | ||
| SI.Pressure pressureLossTurbulent "Turbulent pressure loss"; | ||
| SI.AbsolutePressure pressureLossLaminar "Laminar pressure loss"; | ||
| SI.AbsolutePressure pressureLossTurbulent "Turbulent pressure loss"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure pressureLossTurbulent "Turbulent pressure loss"; | |
| SI.PressureDifference pressureLossTurbulent "Turbulent pressure loss"; |
| input SI.Length l(min=0) "Length"; | ||
|
|
||
| output SI.Pressure pressureLoss "pressure loss (dp)"; | ||
| output SI.AbsolutePressure pressureLoss "pressure loss (dp)"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| output SI.AbsolutePressure pressureLoss "pressure loss (dp)"; | |
| output SI.PressureDifference pressureLoss "pressure loss (dp)"; |
Comment on lines
+9
to
+10
| parameter SI.Temperature | ||
| T_0 = Medium.T_default "Initial Temperature" |
Collaborator
There was a problem hiding this comment.
Suggested change
| parameter SI.Temperature | |
| T_0 = Medium.T_default "Initial Temperature" | |
| parameter SI.Temperature T_0 = Medium.T_default "Initial Temperature" |
Comment on lines
+11
to
+12
| annotation( | ||
| Dialog(tab="Initialization", group="Specific enthalpy", enable=(init == Internal.InitializationMethodsCondElement.T))); |
Collaborator
There was a problem hiding this comment.
Suggested change
| annotation( | |
| Dialog(tab="Initialization", group="Specific enthalpy", enable=(init == Internal.InitializationMethodsCondElement.T))); | |
| annotation(Dialog(tab="Initialization", group="Specific enthalpy", enable=(init == Internal.InitializationMethodsCondElement.T))); |
| input SI.Length Delta(min = 0) "Relaitiv roughness"; | ||
| input SI.Density rho "Inlet density"; | ||
| input SI.DynamicViscosity mu "Dynamic viscosity"; | ||
| input Real Re1 "Lower boundary Re for laminar-turbulent transition regime"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| input Real Re1 "Lower boundary Re for laminar-turbulent transition regime"; | |
| input SI.ReynoldsNumber Re1 "Lower boundary Re for laminar-turbulent transition regime"; |
| input SI.Density rho "Inlet density"; | ||
| input SI.DynamicViscosity mu "Dynamic viscosity"; | ||
| input Real Re1 "Lower boundary Re for laminar-turbulent transition regime"; | ||
| input Real Re2 "Upper boundary Re for laminar-turbulent transition regime"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| input Real Re2 "Upper boundary Re for laminar-turbulent transition regime"; | |
| input SI.ReynoldsNumber Re2 "Upper boundary Re for laminar-turbulent transition regime"; |
| SI.AbsolutePressure p_branching "Total pressure branching inlet"; | ||
| SI.AbsolutePressure p[2] = {p_straight, p_branching} "Total pressure inlets [straight branching]"; | ||
|
|
||
| SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet"; | |
| SI.PressureDifference dq_straight "Dynamic pressure difference straight inlet - outlet"; |
| SI.AbsolutePressure p[2] = {p_straight, p_branching} "Total pressure inlets [straight branching]"; | ||
|
|
||
| SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet"; | ||
| SI.Pressure dq_branching "Dynamic pressure difference straight inlet - outlet"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.Pressure dq_branching "Dynamic pressure difference straight inlet - outlet"; | |
| SI.PressureDifference dq_branching "Dynamic pressure difference straight inlet - outlet"; |
| input SI.Length Delta(min = 0) "Relaitiv roughness"; | ||
| input SI.Density rho "Inlet density"; | ||
| input SI.DynamicViscosity mu "Dynamic viscosity"; | ||
| input Real Re1 "Lower boundary Re for laminar-turbulent transition regime"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| input Real Re1 "Lower boundary Re for laminar-turbulent transition regime"; | |
| input SI.ReynoldsNumber Re1 "Lower boundary Re for laminar-turbulent transition regime"; |
| input SI.Density rho "Inlet density"; | ||
| input SI.DynamicViscosity mu "Dynamic viscosity"; | ||
| input Real Re1 "Lower boundary Re for laminar-turbulent transition regime"; | ||
| input Real Re2 "Upper boundary Re for laminar-turbulent transition regime"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| input Real Re2 "Upper boundary Re for laminar-turbulent transition regime"; | |
| input SI.ReynoldsNumber Re2 "Upper boundary Re for laminar-turbulent transition regime"; |
| SI.AbsolutePressure p_branching "Total pressure branching inlet"; | ||
| SI.AbsolutePressure p[2] = {p_straight, p_branching} "Total pressure inlets [straight branching]"; | ||
|
|
||
| SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet"; | |
| SI.PressureDifference dq_straight "Dynamic pressure difference straight inlet - outlet"; |
| SI.AbsolutePressure p[2] = {p_straight, p_branching} "Total pressure inlets [straight branching]"; | ||
|
|
||
| SI.Pressure dq_straight "Dynamic pressure difference straight inlet - outlet"; | ||
| SI.Pressure dq_branching "Dynamic pressure difference straight inlet - outlet"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.Pressure dq_branching "Dynamic pressure difference straight inlet - outlet"; | |
| SI.PressureDifference dq_branching "Dynamic pressure difference straight inlet - outlet"; |
Comment on lines
+30
to
+31
| SI.Temperature | ||
| T = Medium.temperature(center_state) "Temperature at center state"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.Temperature | |
| T = Medium.temperature(center_state) "Temperature at center state"; | |
| SI.Temperature T = Medium.temperature(center_state) "Temperature at center state"; |
Comment on lines
+26
to
+27
| parameter SI.Temperature | ||
| T_start=Medium.T_default |
Collaborator
There was a problem hiding this comment.
Suggested change
| parameter SI.Temperature | |
| T_start=Medium.T_default | |
| parameter SI.Temperature T_start = Medium.T_default |
Comment on lines
+33
to
+34
| parameter SI.SpecificEnthalpy | ||
| h_start=Medium.h_default |
Collaborator
There was a problem hiding this comment.
Suggested change
| parameter SI.SpecificEnthalpy | |
| h_start=Medium.h_default | |
| parameter SI.SpecificEnthalpy h_start=Medium.h_default |
| SI.Length staticHeadFores[N_fores] | ||
| "distance perpendicular to liquid surface"; | ||
| Medium.AbsolutePressure staticHeadInlets_Pa_relative[N_inlets] | ||
| SI.AbsolutePressure staticHeadInlets_Pa_relative[N_inlets] |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure staticHeadInlets_Pa_relative[N_inlets] | |
| SI.Pressure staticHeadInlets_Pa_relative[N_inlets] |
| SI.AbsolutePressure staticHeadInlets_Pa_relative[N_inlets] | ||
| "relative pressure to liquid surface"; | ||
| Medium.AbsolutePressure staticHeadOutlets_Pa_relative[N_outlets] | ||
| SI.AbsolutePressure staticHeadOutlets_Pa_relative[N_outlets] |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure staticHeadOutlets_Pa_relative[N_outlets] | |
| SI.Pressure staticHeadOutlets_Pa_relative[N_outlets] |
| SI.AbsolutePressure staticHeadOutlets_Pa_relative[N_outlets] | ||
| "relative pressure to liquid surface"; | ||
| Medium.AbsolutePressure staticHeadRears_Pa_relative[N_rears] | ||
| SI.AbsolutePressure staticHeadRears_Pa_relative[N_rears] |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure staticHeadRears_Pa_relative[N_rears] | |
| SI.Pressure staticHeadRears_Pa_relative[N_rears] |
| SI.AbsolutePressure staticHeadRears_Pa_relative[N_rears] | ||
| "relative pressure to liquid surface"; | ||
| Medium.AbsolutePressure staticHeadFores_Pa_relative[N_fores] | ||
| SI.AbsolutePressure staticHeadFores_Pa_relative[N_fores] |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.AbsolutePressure staticHeadFores_Pa_relative[N_fores] | |
| SI.Pressure staticHeadFores_Pa_relative[N_fores] |
Comment on lines
+159
to
+160
| SI.SpecificEnthalpy | ||
| h_in[N_inlets]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.SpecificEnthalpy | |
| h_in[N_inlets]; | |
| SI.SpecificEnthalpy h_in[N_inlets]; |
Comment on lines
+164
to
+165
| SI.SpecificEnthalpy | ||
| h_out[N_outlets]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.SpecificEnthalpy | |
| h_out[N_outlets]; | |
| SI.SpecificEnthalpy h_out[N_outlets]; |
Comment on lines
+173
to
+174
| SI.SpecificEnthalpy | ||
| h_rear[N_rears]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.SpecificEnthalpy | |
| h_rear[N_rears]; | |
| SI.SpecificEnthalpy h_rear[N_rears]; |
Comment on lines
+175
to
+176
| SI.SpecificEnthalpy | ||
| h_fore[N_fores]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.SpecificEnthalpy | |
| h_fore[N_fores]; | |
| SI.SpecificEnthalpy h_fore[N_fores]; |
Comment on lines
+183
to
+184
| SI.DerDensityByPressure | ||
| density_derp_h=(V_ref*medium.d)/(V*K) |
Collaborator
There was a problem hiding this comment.
Suggested change
| SI.DerDensityByPressure | |
| density_derp_h=(V_ref*medium.d)/(V*K) | |
| SI.DerDensityByPressure density_derp_h=(V_ref*medium.d)/(V*K) |
ThermofluidStream/Undirected/Boundaries/Internal/PartialTankUndirected.mo
Outdated
Show resolved
Hide resolved
RaphaelGebhart
requested changes
Feb 24, 2026
…directed.mo Co-authored-by: RaphaelGebhart <159274394+RaphaelGebhart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.