Open
Conversation
>> Color the flow resistance model dynamically based on the pressure drop. Make the coloring optional Introduce a reference value Introduce a reasonable start value.
>> - Now there is a switch in layout of the flow resistance to toggle displaying the dp or not - it can be displayed in which units dp should be displayed (bar, kPa, Pa) - Introduced Types/PressureUnit.mo >> MINOR FIX for DropOfCommons.mo show coloring
tobiasreischl
requested review from
CorentinLepais,
Nicsda,
RaphaelGebhart and
nieweber
CorentinLepais
requested changes
Feb 24, 2026
Contributor
There was a problem hiding this comment.
- Should p_reference be transferred to the layout tab since it is only a parameter impacting the visual aspect and not the model itself?
- The name could also be improved to highlight that it is not a reference pressure used in the calculation. Maybe p_ref_color or something similar.
- Revert all formatting changes which were not intended
- The variable phi can be set as protected I think since it is only used as an internal variable and declared with the other protected variables
- Indentations and line breaks in the annotations to be checked.
- Documentation update to mention the coloring. Maybe add an explanation on how to choose the proper value (should it be the design value, 2 times the design one, ...)
Contributor
There was a problem hiding this comment.
- Documentation for the coloring option should be added.
- Rename the boolean to displayColor to make it consistent with the other display parameters.
- Mention Color in the short description of the parameter or even rephrase it to highlight that it displays the pressure drop with color.
Contributor
There was a problem hiding this comment.
Add documentation, like a short sentence to describe the goal of the enumeration and make sure the Documentation tab is displayed properly.
tobiasreischl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces displaying pressure drop and Coloring for Resistance in TFS