Conversation
tobiasreischl
commented
Dec 11, 2025
tobiasreischl
commented
> Moved all dp text to not cross namings
> Fixes applied from meeting
RaphaelGebhart
left a comment
RaphaelGebhart
left a comment
There was a problem hiding this comment.
Hi Tobi. Here are some suggestions.
| parameter Real k_min(unit="1", min = 1e-5, max = 1) = 0.03 "Remaining flow at actuation signal u = 0"; | ||
|
|
||
| Modelica.Blocks.Interfaces.RealInput u_in(unit="1") "Valve control input signal []" | ||
| annotation (Placement(transformation(extent={{-20,-20},{20,20}},rotation=270,origin={0,80}))); |
There was a problem hiding this comment.
This change should be reverted.
| Boundaries.Sink sink(redeclare package Medium=Medium, p0_par=200000) | ||
| annotation (Placement(transformation(extent={{52,-10},{72,10}}))); | ||
| ThermofluidStream.FlowControl.CheckValve checkValve(redeclare package Medium=Medium, L= | ||
| ThermofluidStream.FlowControl.CheckValve checkValve( |
There was a problem hiding this comment.
displayInstanceName=true is not required. The modifier can be removed.
| offset=1e5) | ||
| annotation (Placement(transformation(extent={{-96,-4},{-76,16}}))); | ||
| Processes.FlowResistance flowResistance(redeclare package Medium=Medium, | ||
| Processes.FlowResistance flowResistance( |
There was a problem hiding this comment.
displayInstanceName=true is not required. The modifier can be removed.
| ThermofluidStream.Boundaries.Sink sink(redeclare package Medium = Medium, p0_par=100000) | ||
| annotation (Placement(transformation(extent={{50,20},{70,40}}))); | ||
| ThermofluidStream.FlowControl.MCV mCV( | ||
| displayInstanceName=true, |
There was a problem hiding this comment.
displayInstanceName=true is not required. The modifier can be removed.
| ThermofluidStream.Boundaries.Sink sink1(redeclare package Medium = Medium, p0_par=100000) | ||
| annotation (Placement(transformation(extent={{50,-10},{70,10}}))); | ||
| ThermofluidStream.FlowControl.MCV mCV1( | ||
| displayInstanceName=true, |
There was a problem hiding this comment.
displayInstanceName=true is not required. The modifier can be removed.
| rotation=180), | ||
| Text( | ||
| visible=displayParameters, | ||
| extent={{-100,96},{100,66}}, |
There was a problem hiding this comment.
As noted elsewhere.
|
|
||
| annotation (Icon(coordinateSystem(preserveAspectRatio=true), graphics={ | ||
| Line( | ||
| points={{0,4},{0,106}}, |
There was a problem hiding this comment.
As noted elsewhere
| // Adding color to the icon | ||
| // Normalize pressure ratio into [0,1] | ||
| phi = max(0, min(1, abs(dp) / (abs(dp_ref) + p_min))); | ||
|
|
There was a problem hiding this comment.
p_min is not required. I would suggest a different normalization.
|
|
||
| k_u = valveCharacteristics(u, k_min); | ||
|
|
||
| // Adding color to the icon |
| annotation(Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.m_flow_set))); | ||
|
|
||
| Real phi(min = 0, max = 1) "Normalized pressure"; | ||
|
|
There was a problem hiding this comment.
Remove blank lines.
3 participants
