Skip to content

added .metadata for Modelon Impact at top level#230

Open
hubertus65 wants to merge 9 commits intoDLR-SR:mainfrom
hubertus65:main
Open

added .metadata for Modelon Impact at top level#230
hubertus65 wants to merge 9 commits intoDLR-SR:mainfrom
hubertus65:main

Conversation

@hubertus65
Copy link

@hubertus65 hubertus65 commented Apr 11, 2025

Would you consider to include Modelon Impact metadata at the top level? It's a small file, and makes it possible for Modelon Impact user to work directly against your source repository.

There were also some changes that didn't work in Modelon Impact: it does not support conditional IconTransformations yet. Everything works and is fully tested with the refactoring. I proposed to support that feature in the future in Modelon Impact.

Some of my commits were just clean-up, removing unneeded files. With the .impact-directory and one json files, people can work directly in Modelon Impact against the main repository.
/Hubertus

hubertus65 and others added 2 commits April 16, 2025 16:11
accepted suggestion

Co-authored-by: tobolar <tobolar@users.noreply.github.com>
@nieweber
Copy link
Contributor

Hey Hubertus,

thank you for your pull request. First of all, adding the .impact folder to the repository top-level is fine.

Regarding the conditional icon transformations:
we would like to keep a single partial model for the heat exchangers and separate the interface from the partial model. We are just working internally on a solution how to do that the best way. I'd therefore like to ask you, if you could "split" that pull request and separate the adding of the .impact folder and the icon issue?

Also another question popped up:
does the display of component parameters work properly in Modelon Impact (if you set dropOfCommons.displayParameters = true) ?

Best regards
Niels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants