added .metadata for Modelon Impact at top level#230
Open
hubertus65 wants to merge 9 commits intoDLR-SR:mainfrom
Open
added .metadata for Modelon Impact at top level#230hubertus65 wants to merge 9 commits intoDLR-SR:mainfrom
hubertus65 wants to merge 9 commits intoDLR-SR:mainfrom
Conversation
…on in Modelon Impact: Library now fully compatible (again) with Modelon Impact
removed irrelevant things
tobolar
reviewed
Apr 16, 2025
tobolar
reviewed
Apr 16, 2025
accepted suggestion Co-authored-by: tobolar <tobolar@users.noreply.github.com>
Contributor
|
Hey Hubertus, thank you for your pull request. First of all, adding the .impact folder to the repository top-level is fine. Regarding the conditional icon transformations: Also another question popped up: Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would you consider to include Modelon Impact metadata at the top level? It's a small file, and makes it possible for Modelon Impact user to work directly against your source repository.
There were also some changes that didn't work in Modelon Impact: it does not support conditional IconTransformations yet. Everything works and is fully tested with the refactoring. I proposed to support that feature in the future in Modelon Impact.
Some of my commits were just clean-up, removing unneeded files. With the .impact-directory and one json files, people can work directly in Modelon Impact against the main repository.
/Hubertus