Draft
Conversation
…se 'digits' as significantDigits instead of decimal places (nachkommastellen), i.e. 'DynamicSelect(' 0.0 ', ' '+String(value,significantDigits=digits)+' ')'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default value
0.0instead ofvalue(according toModelica.Blocks.Interaction.Show.RealValue)significant digits
DynamicSelect(" 0.0 ", " "+String(value,significantDigits=digits)+" ")instead ofDynamicSelect("value", String(value,format="1."+String(digits)+"f"))(according toModelica.Blocks.Interaction.Show.RealValue)defaultComponentName = "sensor"instead of"singleSensorSelect"because both "single" and "select" are meaningless in my opinion (i would actually appreciate if we changed the sensor component names)Rectangle(extent={{-60,30},{60,-30}})impliesText(extent={{-60,26},{60,-26}}), i.e. text is smaller (vertical) than the surrounding rectangle. horizontally this is considered by white spaces" "+String(value,significantDigits=digits)+" "(according toModelica.Blocks.Interaction.Show.RealValue)better usage of available space (x_min = -80, instead of x_min = -60 and (x_max = +80, instead of x_max = +60 to maintain symmetry), i.e.
Text(extent={{-80,26},{80,-26}})instead ofText(extent={{-60,26},{60,-26}}), adapted the shadow and removed the line which is not visible anymore nowLine(points={{-100,0},{0,0}},color={28,108,200},thickness=0.5)text color black instead of blue: better to read and better to distinguish sensor value <-> fluid flow


output connector position according to MSL, i.e.
Placement(transformation(extent={{100,-10},{120,10}}))and adapt the corresponding lineadapt
Sensors.MultiSensor_Tpm(etc.) to the changes, i.e. move the unit display, e.g.Text(visible=not outputTemperature,extent={{150,67},{90,37}}, textString=temperatureString, horizontalAlignment=TextAlignment.Left), and move the complete box upwards by 10px to be similar toSensors.SingleFlowSensorremoved
iconTransformation = ...iftransformation = ...is sufficient, similar to Annotation update + use of defaultComponentName #214using
adaptDisplaywhich will yield 1)if outputVale==true, thatvalueis not displayed (onlyquantityString), 2)if outputVale==false, thatquantityStringis displayed on the right of the sensor display, instead of below/above.