Properly initialize spectest #296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `Store::instance_export` from the Embedder API instead. If module name resolution is required, additionally use a linker. Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Only exported items should be visible to the host. Therefore, exposing the indices of items to the host does not make any sense. Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
…Instance` Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Use `Store::module_instantiate` or `Linker::module_instantiate` instead. Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
Signed-off-by: Florian Hartung <[email protected]>
github-actions
bot
added
execution
validation
tests
examples
priority-high
priority-medium
priority-low
labels
florianhartung
force-pushed
the
dev/init-spectest
branch
from
d554972 to
e9feb70
Compare
Contributor
🗒️ WebAssembly Testsuite ReportNo changes detected Per-test detailsClick here to open
|
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Florian Hartung <[email protected]>
The spectest module should be initialized through the Embedder API. This is safer, because it does not rely on the fact that our parsing and validation algorithms are correct. Signed-off-by: Florian Hartung <[email protected]>
florianhartung
force-pushed
the
dev/init-spectest
branch
from
e9feb70 to
29e887a
Compare
cemonem
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is based on #295. Only the last commit is relevant for this PR
The special spectest module should be initialized through the Embedder API, not as Wasm code itself.
nix fmtnix flake check '.?submodules=1'cargo fmtcargo testcargo checkcargo buildcargo doc