Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPI workflow to use trusted publishing #342

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

j08lue
Copy link
Collaborator

@j08lue j08lue commented Aug 9, 2024

Recent failure in PyPI publication workflow on release v0.8.4 was due an issue with my PyPI account, but I am using this occasion to update the workflow to follow latest recommendations.

Addresses

@j08lue
Copy link
Collaborator Author

j08lue commented Aug 9, 2024

Tests are failing because crick does not yet have wheels with Numpy 2.0 on PyPI.

They do exist on Conda, therefore tests pass there.

@j08lue
Copy link
Collaborator Author

j08lue commented Aug 9, 2024

Should we limit Numpy to v1 for now, or wait for crick to publish new wheels? 🤷

I'll see how fast crick maintainers respond.

@dionhaefner
Copy link
Collaborator

Thanks, let's give this a try.

@dionhaefner dionhaefner merged commit 72c7d79 into main Aug 11, 2024
4 of 7 checks passed
@dionhaefner
Copy link
Collaborator

dionhaefner commented Aug 11, 2024

@j08lue Looks like some config is still missing: https://github.com/DHI/terracotta/actions/runs/10342070326

@j08lue j08lue deleted the fix/pypi-workflow branch August 12, 2024 08:37
@j08lue
Copy link
Collaborator Author

j08lue commented Aug 12, 2024

Yes, it was. Now set up:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants