Repository navigation
diag: runGit reap survivor on windows - #50
Closed
Zelys-DFKH wants to merge 3 commits into
Closed
Zelys-DFKH wants to merge 3 commits into
Zelys-DFKH wants to merge 3 commits into
Conversation
…rt64 Git 2.56.0.windows.2 on the windows-latest image has no mingw64 folder: its real git is Git/ucrt64/bin/git.exe. realGitBehindLauncher only knew mingw64, clangarm64 and mingw32, so gitExecutable answered plain git, runGit spawned the bin/git.exe launcher again, and a timeout killed the launcher and orphaned the real git (CI run 39003789603: the survivor was the pack-refs git whose parent launcher was already dead). The folder list now includes ucrt64 and clang64, and any other folder beside the launcher that holds a bin/git.exe is used as a fallback, so the next rename cannot bring the orphan back. The test/diag commit is reverted in the same change.
runGit now starts the real git by its full path where Git for Windows keeps a launcher first on PATH. Four tests spied on spawnSync for the bare word git, which the Windows runner never matched before the launcher fix, so with the fix on CI two shards went red (stale_index_warns_on_multi_file_answers, cmdindex_priority_after_enumeration; CI run 39006233592) and two probes would have gone blind. They now match the file name, with or without .exe.
Collaborator
Author
|
Diagnosis and fix verified on CI run 39008990382; closing without merge, branch reapci left for the orchestrator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, diagnostics only. Do not merge.