Skip to content

diag: runGit reap survivor on windows - #50

Closed
Zelys-DFKH wants to merge 3 commits into
mainfrom
reapci
Closed

Zelys-DFKH wants to merge 3 commits into
mainfrom
reapci

Conversation

@Zelys-DFKH

Copy link
Copy Markdown
Collaborator

Draft, diagnostics only. Do not merge.

…rt64

Git 2.56.0.windows.2 on the windows-latest image has no mingw64 folder: its real git is Git/ucrt64/bin/git.exe. realGitBehindLauncher only knew mingw64, clangarm64 and mingw32, so gitExecutable answered plain git, runGit spawned the bin/git.exe launcher again, and a timeout killed the launcher and orphaned the real git (CI run 39003789603: the survivor was the pack-refs git whose parent launcher was already dead).

The folder list now includes ucrt64 and clang64, and any other folder beside the launcher that holds a bin/git.exe is used as a fallback, so the next rename cannot bring the orphan back. The test/diag commit is reverted in the same change.
runGit now starts the real git by its full path where Git for Windows keeps a launcher first on PATH. Four tests spied on spawnSync for the bare word git, which the Windows runner never matched before the launcher fix, so with the fix on CI two shards went red (stale_index_warns_on_multi_file_answers, cmdindex_priority_after_enumeration; CI run 39006233592) and two probes would have gone blind. They now match the file name, with or without .exe.
@Zelys-DFKH

Copy link
Copy Markdown
Collaborator Author

Diagnosis and fix verified on CI run 39008990382; closing without merge, branch reapci left for the orchestrator.

@Zelys-DFKH Zelys-DFKH closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant