Reduced diameter of star as thickness increases to fit within bounding box #1445
Conversation
changelog.txt
Outdated
| - The default has 5 points, use 'B'/'b' to increase/decrease points. | ||
| - They can be hollow or filled, and inverted. | ||
| - The next-point offset can be increased/decreased using 'N'/'n' which particularly affects 7 point stars and above to make them spikier or smoother, but can also be used to decrease to 1 to make symmetrical polygons or increase to N which only paints the vertexes. | ||
| - The orientation can be changed by adding a main axis point using 'v' and moving this to point in the desired direction. |
There was a problem hiding this comment.
the changelog won't render multi-line messages correctly. could you add this info to the docs/gui/design.rst file instead?
changelog.txt
Outdated
|
|
||
| ## Fixes | ||
|
|
||
| - `gui/design`: reduced diameter of star as thickness increases to remain within bounding box |
There was a problem hiding this comment.
no need for a "fixes" line for the star shape since it hasn't been out in a release yet. However, if this fixes the bulge for the line shape, I'd say that deserves a "fixes" entry.
There was a problem hiding this comment.
What's the bulge in the line shape issue?
There was a problem hiding this comment.
Made the horizontal and vertical thickness consistent for curved lines as well, maybe this is the bulge you were referring to.
|
I'm not sure if this fixes the issue. I was still able to draw a star that extended beyond the edge of the map: |
When I draw this exact size star I get the following result: 
Am I missing something? |
I'll test again, likely not properly synced on my part |
Reduced diameter of hollow star as the thickness increases so it does not exceed its bounding box.
Adjusted original changelog entry to contain more details about usage.