bugfix: Post MSA release bug fixes - #1645
Conversation
jag-nahl-airelogic
commented
Jul 27, 2026
jag-nahl-airelogic
commented
- Fixed microcopy constant on categoryLandingPage
- Added ContinueSelfAssessment page to the ChangeSchool banner exclusion list.
- Changed the select schools for single school to still use session instead of cookie as that is still technically a bulk assessment and sessions/cookies is how we differentiate that for now.
- Included `GetContinueSelfAssessment` action in `_Layout.cshtml` hashset for improved navigation. - Resolved incorrect microcopy key for topics without establishment names in `SectionAssessmentLink.cshtml`.
…atMultiSchoolAssessment` - Deleted outdated single-school selection tests and related methods from `GroupsViewBuilder`. - Replaced `IsMatMultiSchoolAssessment` with `IsMatBulkAssessment` throughout the solution for clarity and consistency. - Introduced unit tests for bulk assessment logic in `MatEstablishmentProviderTests`.
…rs and Question views
|
@gilaineyo - I've put some post release MSA fixes here. One thing needing to be fixed was that we needed too display the school selected dropdown on question pages. The only way we currently have to differentiate between bulk assessment and single school assessment was sessions vs cookies. In the select schools bit, you put a if statement of "if the selection is 1" then we just select the school and set the cookie instead otherwise use session. I've removed this and just left it all within the loop so it adds it to the session if any amount is selected. I just wanted to check if there was a specific reason we had that if statement or if it is ok as it is now in the PR? Thanks |
…on and handling - Added explicit validation for single school selection, ensuring proper group membership and required data. - Improved in-progress submission handling by differentiating between single and multiple school selections. - Updated session management logic for selected schools.
…nto bugfix/post-release-bug-fixes
…sViewBuilder - Consolidated logic for single and multiple school selections, improving readability and maintainability. - Strengthened validation checks for group membership and school data integrity. - Refined session management for selected schools and in-progress submissions.
|
@gilaineyo I've put back the original code and just added the line that adds it to the session. Removing the selected cookie causes issues with continue self-assessment (probably a future task to sort out sessions/cookie and get it all within sessions). Tested single, in-progress, multiple and all and all seems to be working. |
|
2 participants
