Feature/839 profile page pagination - #487
Merged
Merged
Conversation
…omparison once multi-phase. Some renaming might be needed in future Note where 'at-a-glance' overview will go make only 16-19 l2/l3 variable
|
Review app for PR 487 was deleted |
naomitodd
marked this pull request as ready for review
August 24, 2026 08:25
GKahlon-DfE
previously approved these changes
Aug 24, 2026
GKahlon-DfE
previously approved these changes
Aug 24, 2026
SummarySummary
CoverageSAPData - 75.7%
SAPPub.Core - 87.6%
SAPPub.Infrastructure - 58.4%
SAPPub.Web - 90.2%
|
|
No critical or severe accessibility issues found |
stuw-dfe
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add pagination for school profiles, handling phases/feature flags and variable pages that can be hidden.
Added SchoolProfileSitemap that can be extended & should be able to reuse logic to add a ComparisonSitemap when more phases are added.
Resolver tests.
UI Playwright tests for interaction & clicking through pages.
Page tests for each page to make sure wired up correctly but using href in case copy continues to change.
Will need some update when 'at a glance' added but should just need adding to sitemap & minor test updates.
Values will need passing through to determine if 16-to19 L2/L3 links should be shown - note added to relevant ticket.
https://trello.com/c/SgTuBJJe/839-multi-phase-bottom-pagination
Type of change
Please delete options that are not relevant.
Checklist: