16-19 (FE) Stage 2 - Story 3d.ii - Academic performance - Academic qualifications: Additional data by rgaddam-dfe · Pull Request #476 · DFE-Digital/sap-public

rgaddam-dfe · 2026-08-18T09:30:46Z

Description

16-19 (FE) Stage 2 - Story 3d.ii - Academic performance - Academic qualifications: Additional data

Implemented a journey to view additional data for Academic qualifications
Implemented changes to KS5PerformanceRepository to fetch establishmnet, england and La performance data related to Academic qualifications additional data
Implemented changes to Level3QualificationsService to fetch establishmnet, england and La performance data related to Academic qualifications
Added new properties to KS5 performance additional data for Academic qualifications
Added new properties related to additional data for a levels in service models for KS5 performance
Implemented changes to page to show additional data in the UI
Implemented logic to show additional data for Academic qualifications
Added unit tests

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

…alifications: Additional data - Implemented a journey to view additional data for Academic qualifications - Implemented changes to KS5PerformanceRepository to fetch establishmnet, england and La performance data related to Academic qualifications additional data - Implemented changes to Level3QualificationsService to fetch establishmnet, england and La performance data related to Academic qualifications - Added new properties to KS5 performance additional data for Academic qualifications - Added new properties related to additional data for a levels in service models for KS5 performance - Implemented changes to page to show additional data in the UI - Implemented logic to show additional data for Academic qualifications - Added unit tests

github-actions · 2026-08-18T09:39:53Z

Review app for PR 476 was deleted

github-actions · 2026-08-18T15:55:18Z

Summary


Generated on:	08/18/2026 - 15:55:15
Parser:	Cobertura
Assemblies:	4
Classes:	171
Files:	168
Line coverage:	81% (3649 of 4504)
Covered lines:	3649
Uncovered lines:	855
Coverable lines:	4504
Total lines:	11450
Branch coverage:	67.6% (434 of 642)
Covered branches:	434
Total branches:	642
Method coverage:	Feature is only available for sponsors

Coverage

SAPData - 75.7%

Name	Line	Branch
SAPData	75.7%	63.4%
SAPData.Filters.SqlViewFilterProvider	100%	100%
SAPData.GenerateIndexes	100%	100%
SAPData.GenerateRawTables	58.6%	39%
SAPData.GenerateViews	81.4%	75.9%
SAPData.KeyStageConstants	100%
SAPData.Models.DataMapMapping	0%

SAPPub.Core - 87.2%

Name	Line	Branch
SAPPub.Core	87.2%	85.2%
SAPPub.Core.ApplicationServices.EntityPropertyService	0%	0%
SAPPub.Core.Attributes.DbColumnNameAttribute	0%
SAPPub.Core.Enums.Progress8BandingExtensions	100%	100%
SAPPub.Core.Exceptions.NotFoundException	100%
SAPPub.Core.Extensions.DoubleExtensions	100%
SAPPub.Core.Extensions.EducationPhaseFormatter	100%	100%
SAPPub.Core.Extensions.EstablishmentExtensions	100%
SAPPub.Core.Extensions.EstablishmentStatusExtensions	94.7%
SAPPub.Core.Extensions.SchoolSearchDocumentExtensions	100%
SAPPub.Core.Extensions.StringExtensions	100%	100%
SAPPub.Core.Helpers.AcademicYearsHelper	100%
SAPPub.Core.Helpers.MappingHelper	88.8%
SAPPub.Core.Helpers.TextHelpers	86.6%	100%
SAPPub.Core.ServiceModels.Common.Pager	75%
SAPPub.Core.ServiceModels.EstablishmentServiceModel	100%
SAPPub.Core.ServiceModels.KS4.Performance.AdditionalMeasuresModel	100%
SAPPub.Core.ServiceModels.Search.InputModels.SearchQuery	100%
SAPPub.Core.Services.DestinationsService	100%
SAPPub.Core.Services.EmailService	100%	100%
SAPPub.Core.Services.EstablishmentService	100%
SAPPub.Core.Services.Gateway.GatewayLocalAuthorityService	0%
SAPPub.Core.Services.Gateway.GatewaySettingsService	0%
SAPPub.Core.Services.Gateway.GatewayUserAuditService	0%
SAPPub.Core.Services.Gateway.GatewayUserLAService	0%
SAPPub.Core.Services.Gateway.GatewayUserService	0%
SAPPub.Core.Services.KS4.Absence.EnglandAbsenceService	100%
SAPPub.Core.Services.KS4.Absence.EstablishmentAbsenceService	100%
SAPPub.Core.Services.KS4.Absence.LAAbsenceService	100%
SAPPub.Core.Services.KS4.Attendance.AttendanceService	100%	100%
SAPPub.Core.Services.KS4.Performance.EnglandPerformanceService	100%
SAPPub.Core.Services.KS4.Performance.EnglishAndMathsResultsService	100%
SAPPub.Core.Services.KS4.Performance.EstablishmentPerformanceService	100%
SAPPub.Core.Services.KS4.Performance.LAPerformanceService	100%
SAPPub.Core.Services.MySchoolsListService	95.2%	100%
SAPPub.Core.Services.Performance.KS2MeetingOrExceedingStandardsService	100%
SAPPub.Core.Services.Performance.KS2ScaledScoresService	100%
SAPPub.Core.Services.Performance.KS4EstablishmentSubjectEntriesService	100%	100%
SAPPub.Core.Services.Performance.KS5EstablishmentSubjectEntriesService	100%
SAPPub.Core.Services.Performance.Level2QualificationsService	85.1%
SAPPub.Core.Services.Performance.Level3QualificationsService	100%	100%
SAPPub.Core.Services.Search.FeatureFlagSearchVisibilityPolicy	0%
SAPPub.Core.Specifications.SearchVisibilitySpecification	100%	100%
SAPPub.Core.ValueObjects.CodedDouble	100%
SAPPub.Core.ValueObjects.CodedString	100%

SAPPub.Infrastructure - 55.5%

Name	Line	Branch
SAPPub.Infrastructure	55.5%	22.9%
SAPPub.Infrastructure.Mapping.ValueCodes.CodedDoubleTypeHandler	9%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.CodedStringTypeHandler	10%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.ReasonCodeLookup	50%
SAPPub.Infrastructure.Mapping.ValueCodes.ReflectionCodedValueMapper	0%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.ValueCodeParser	0%	0%
SAPPub.Infrastructure.PostcodeLookup.PostcodeLookupService	100%
SAPPub.Infrastructure.PostgresSearch.PostgresSchoolSearchIndexReader	100%
SAPPub.Infrastructure.Repositories.Destinations.KS4DestinationsRepository	0%
SAPPub.Infrastructure.Repositories.EmailRepository	94.1%
SAPPub.Infrastructure.Repositories.EstablishmentRepository	100%	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayLocalAuthorityRepository	100%	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayUserAuditRepository	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayUserRepository	100%
SAPPub.Infrastructure.Repositories.Generic.DapperCommandBuilder	0%	0%
SAPPub.Infrastructure.Repositories.Generic.DapperRepository`1	90%	100%
SAPPub.Infrastructure.Repositories.Generic.JSONRepository`1	0%	0%
SAPPub.Infrastructure.Repositories.Helpers.DapperHelpers	60.2%	0%
SAPPub.Infrastructure.Repositories.KS4.Absence.EnglandAbsenceRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Absence.EstablishmentAbsenceReposito ry	100%
SAPPub.Infrastructure.Repositories.KS4.Absence.LAAbsenceRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.EnglandPerformanceReposi tory	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.EstablishmentPerformance Repository	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.LAPerformanceRepository	100%
SAPPub.Infrastructure.Repositories.LaUrlsRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS2PerformanceRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS4EstablishmentSubjectEntri esRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS5EstablishmentSubjectEntri esRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS5PerformanceRepository	100%

SAPPub.Web - 88.9%

Name	Line	Branch
SAPPub.Web	88.9%	82.2%
SAPPub.Web.Areas.Compare.Controllers.SecondaryController	100%
SAPPub.Web.Areas.Compare.Filters.SecondaryComparisonQueryValidationAttribut e	0%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareAboutYourSchoolsViewMo del	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareAcademicPerformanceEng lishAndMathsResultsViewModel	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareAcademicPerformancePup ilAttainmentViewModel	100%	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareDestinationsViewModel	100%	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareNextStepsViewModel	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareSecondarySchoolBaseVie wModel	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.SchoolAttainmentDetailsViewMo del	100%	100%
SAPPub.Web.Areas.Gateway.Controllers.GatewayController	53%	50%
SAPPub.Web.Areas.Profiles.Controllers.AboutController	100%
SAPPub.Web.Areas.Profiles.Controllers.AdmissionsController	100%
SAPPub.Web.Areas.Profiles.Controllers.CurriculumController	100%
SAPPub.Web.Areas.Profiles.Controllers.DestinationsController	100%
SAPPub.Web.Areas.Profiles.Controllers.KS2Controller	100%
SAPPub.Web.Areas.Profiles.Controllers.KS4Controller	100%
SAPPub.Web.Areas.Profiles.Controllers.KS5Controller	52.6%
SAPPub.Web.Areas.Profiles.Filters.DfEAnalyticsAddPhaseTagFilter	0%
SAPPub.Web.Areas.Profiles.Filters.PrimaryQueryValidationFilter	0%
SAPPub.Web.Areas.Profiles.Helpers.AcademicYearSelectionExtensions	94.4%	100%
SAPPub.Web.Areas.Profiles.Helpers.GcseGradeSelectionExtensions	64.2%	50%
SAPPub.Web.Areas.Profiles.ViewModels.AboutSchool.AboutSchoolViewModel	100%	100%
SAPPub.Web.Areas.Profiles.ViewModels.Admissions.AdmissionsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.Attendance.AttendanceViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.Destinations.KS4DestinationsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.Destinations.KS5DestinationsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformanceAdditionalMeasu resViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformanceMeetingOrExceed ingStandardsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformancePupilProgressVi ewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformanceSubjectScaledSc oresViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.CurriculumAndExtraCurricularActivi tiesViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS4.AcademicPerformanceAttainmentAndPr ogressViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS4.AcademicPerformanceSubjectsEntered ViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS4.CurriculumAndExtraCurricularActivi tiesViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.AdditionalDataViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.AverageResultViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.EnglishMathsQualificationsViewMode l	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.EnglishMathsScoreViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.Ks5SubjectEnteredViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.KS5ViewModel	0%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.Level2QualificationViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.Level3QualificationViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.ProgressScoreViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.ProfileBaseViewModel	100%	100%
SAPPub.Web.Areas.Profiles.ViewModels.SimpleCodedDoubleTableViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.SubjectsEnteredBaseModel	66.6%
SAPPub.Web.Constants.Constants	100%
SAPPub.Web.Controllers.CookiesController	90.4%	100%
SAPPub.Web.Controllers.ErrorController	82.3%	100%
SAPPub.Web.Controllers.HealthController	67.5%	100%
SAPPub.Web.Controllers.HelpController	100%
SAPPub.Web.Controllers.HomeController	100%
SAPPub.Web.Controllers.MySchoolsController	100%	100%
SAPPub.Web.Controllers.MySchoolsListController	100%	100%
SAPPub.Web.Controllers.SchoolController	0%
SAPPub.Web.Controllers.SearchController	100%	100%
SAPPub.Web.Extensions.HttpContextExtensions	0%	0%
SAPPub.Web.Helpers.AttainmentHelper	98.3%	100%
SAPPub.Web.Helpers.CommonHelper	100%	100%
SAPPub.Web.Helpers.DisplayField`1	67.6%	50%
SAPPub.Web.Helpers.DisplayFieldExtensions	100%	100%
SAPPub.Web.Helpers.EnumHelper	100%
SAPPub.Web.Helpers.ProgressBandingHelper	77.7%
SAPPub.Web.Helpers.TempDataHelper	100%	100%
SAPPub.Web.Helpers.UrlHelper	100%	100%
SAPPub.Web.Middleware.DependenciesExtensions	100%	100%
SAPPub.Web.Middleware.GatewayMiddleware	100%	100%
SAPPub.Web.Middleware.GatewayMiddlewareExtensions	0%
SAPPub.Web.Middleware.NotFoundExceptionHandler	50%	50%
SAPPub.Web.Middleware.SecurityHeadersMiddleware	89.1%
SAPPub.Web.Middleware.SecurityHeadersMiddlewareExtensions	100%
SAPPub.Web.Models.BaseViewModel	80%	100%
SAPPub.Web.Models.Common.PagerViewModel	62%	100%
SAPPub.Web.Models.Common.PaginationItem	85.7%
SAPPub.Web.Models.ErrorViewModel	0%
SAPPub.Web.Models.MySchools.MySchoolModel	100%
SAPPub.Web.Models.MySchools.MySchoolsListViewModel	100%
SAPPub.Web.Models.MySchools.RemoveSchoolViewModel	100%
SAPPub.Web.Models.Search.SearchResult	100%	100%
SAPPub.Web.Models.Search.SearchResultsViewModel	100%	100%
SAPPub.Web.Models.SecondarySchool.AcademicPerformanceAdditionalMeasuresView Model	100%
SAPPub.Web.Models.SecondarySchool.AcademicPerformanceEnglishAndMathsResults ViewModel	100%
SAPPub.Web.Models.SecondarySchool.SuccessorOrPredecessorDetailsModel	100%
SAPPub.Web.ViewComponents.Banner.Banner	100%
SAPPub.Web.ViewComponents.ChartWithTableToggle.ChartWithTableToggle	100%
SAPPub.Web.ViewComponents.MySchools.AddSchoolButton	100%
SAPPub.Web.ViewComponents.Pagination.Pagination	100%
SAPPub.Web.ViewComponents.VerticalNavigation.VerticalNavigation	100%
SAPPub.Web.ViewComponents.VerticalNavigation.VerticalNavigationModel	50%	0%
SAPPub.Web.ViewComponents.VerticalNavigationCompareSecondary.VerticalNaviga tionCompareSecondary	100%
SAPPub.Web.ViewComponents.VerticalNavigationCompareSecondary.VerticalNaviga tionCompareSecondaryModel	0%	0%
SAPPub.Web.ViewComponents.VerticalNavigationMySchools.VerticalNavigationMyS chools	100%
SAPSec.Web.Setup.WebApplicationBuilderExtensions	33.8%	12.5%

github-actions · 2026-08-18T15:55:21Z

No critical or severe accessibility issues found

rgaddam-dfe added the deploy A Review App will be created for PRs with this label label Aug 18, 2026

rgaddam-dfe temporarily deployed to review August 18, 2026 09:37 — with GitHub Actions Inactive

stuw-dfe previously approved these changes Aug 18, 2026

View reviewed changes

rgaddam-dfe added the refresh data The data pipeline will run as part of this deployment. label Aug 18, 2026

rgaddam-dfe temporarily deployed to review August 18, 2026 14:39 — with GitHub Actions Inactive

rgaddam-dfe temporarily deployed to review August 18, 2026 14:40 — with GitHub Actions Inactive

Merge branch 'main' into feature/additional-data-academic-qualifications

20075d5

rgaddam-dfe dismissed stuw-dfe’s stale review via 20075d5 August 18, 2026 15:48

rgaddam-dfe deployed to review August 18, 2026 15:55 — with GitHub Actions View deployment

rgaddam-dfe temporarily deployed to review August 18, 2026 15:56 — with GitHub Actions Inactive

stuw-dfe approved these changes Aug 18, 2026

View reviewed changes

rgaddam-dfe merged commit 7e7c4bc into main Aug 18, 2026
14 checks passed

rgaddam-dfe deleted the feature/additional-data-academic-qualifications branch August 18, 2026 16:09

rgaddam-dfe temporarily deployed to review August 18, 2026 16:09 — with GitHub Actions Inactive

Navigation Menu

Uh oh!

16-19 (FE) Stage 2 - Story 3d.ii - Academic performance - Academic qualifications: Additional data - #476

16-19 (FE) Stage 2 - Story 3d.ii - Academic performance - Academic qualifications: Additional data#476
rgaddam-dfe merged 2 commits into
mainfrom
feature/additional-data-academic-qualifications

rgaddam-dfe commented Aug 18, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

rgaddam-dfe commented Aug 18, 2026

Description

Type of change

Checklist:

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026

Summary

Coverage

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Aug 18, 2026 •

edited

Loading