Feature/602 add primary school features by naomitodd · Pull Request #475 · DFE-Digital/sap-public

naomitodd · 2026-08-17T13:29:54Z

Description

add primary features to about page - adding nursery provision to establishment view and logic for true value

moved feature flags to views & updated page tests

tidied up page tests into relevant folders
fixed bug with vertical nav when there's primary/secondary sub-tabs & updated associated tests

https://trello.com/c/FTOqH0O1/602-1c-add-new-primary-school-features-section-to-the-about-the-school-page-for-primary-schools-only-wraparound-care-and-free-breakf

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

in view only to keep it simple

github-actions · 2026-08-17T13:45:30Z

Review app for PR 475 was deleted

…ng tests, only set if needed

…ts - fix bug with vertical nav TODO curriculum page tests

github-actions · 2026-08-18T12:58:31Z

Summary


Generated on:	08/18/2026 - 12:58:29
Parser:	Cobertura
Assemblies:	4
Classes:	171
Files:	168
Line coverage:	81% (3660 of 4515)
Covered lines:	3660
Uncovered lines:	855
Coverable lines:	4515
Total lines:	11446
Branch coverage:	68.4% (452 of 660)
Covered branches:	452
Total branches:	660
Method coverage:	Feature is only available for sponsors

Coverage

SAPData - 75.7%

Name	Line	Branch
SAPData	75.7%	63.4%
SAPData.Filters.SqlViewFilterProvider	100%	100%
SAPData.GenerateIndexes	100%	100%
SAPData.GenerateRawTables	58.6%	39%
SAPData.GenerateViews	81.4%	75.9%
SAPData.KeyStageConstants	100%
SAPData.Models.DataMapMapping	0%

SAPPub.Core - 87.4%

Name	Line	Branch
SAPPub.Core	87.4%	88.3%
SAPPub.Core.ApplicationServices.EntityPropertyService	0%	0%
SAPPub.Core.Attributes.DbColumnNameAttribute	0%
SAPPub.Core.Enums.Progress8BandingExtensions	100%	100%
SAPPub.Core.Exceptions.NotFoundException	100%
SAPPub.Core.Extensions.DoubleExtensions	100%
SAPPub.Core.Extensions.EducationPhaseFormatter	100%	100%
SAPPub.Core.Extensions.EstablishmentExtensions	100%
SAPPub.Core.Extensions.EstablishmentStatusExtensions	94.7%	100%
SAPPub.Core.Extensions.SchoolSearchDocumentExtensions	100%
SAPPub.Core.Extensions.StringExtensions	100%	100%
SAPPub.Core.Helpers.AcademicYearsHelper	100%
SAPPub.Core.Helpers.MappingHelper	88.8%	100%
SAPPub.Core.Helpers.TextHelpers	86.6%	100%
SAPPub.Core.ServiceModels.Common.Pager	75%
SAPPub.Core.ServiceModels.EstablishmentServiceModel	100%
SAPPub.Core.ServiceModels.KS4.Performance.AdditionalMeasuresModel	100%
SAPPub.Core.ServiceModels.Search.InputModels.SearchQuery	100%
SAPPub.Core.Services.DestinationsService	100%
SAPPub.Core.Services.EmailService	100%	100%
SAPPub.Core.Services.EstablishmentService	100%
SAPPub.Core.Services.Gateway.GatewayLocalAuthorityService	0%
SAPPub.Core.Services.Gateway.GatewaySettingsService	0%
SAPPub.Core.Services.Gateway.GatewayUserAuditService	0%
SAPPub.Core.Services.Gateway.GatewayUserLAService	0%
SAPPub.Core.Services.Gateway.GatewayUserService	0%
SAPPub.Core.Services.KS4.Absence.EnglandAbsenceService	100%
SAPPub.Core.Services.KS4.Absence.EstablishmentAbsenceService	100%
SAPPub.Core.Services.KS4.Absence.LAAbsenceService	100%
SAPPub.Core.Services.KS4.Attendance.AttendanceService	100%	100%
SAPPub.Core.Services.KS4.Performance.EnglandPerformanceService	100%
SAPPub.Core.Services.KS4.Performance.EnglishAndMathsResultsService	100%
SAPPub.Core.Services.KS4.Performance.EstablishmentPerformanceService	100%
SAPPub.Core.Services.KS4.Performance.LAPerformanceService	100%
SAPPub.Core.Services.MySchoolsListService	95.2%	100%
SAPPub.Core.Services.Performance.KS2MeetingOrExceedingStandardsService	100%
SAPPub.Core.Services.Performance.KS2ScaledScoresService	100%
SAPPub.Core.Services.Performance.KS4EstablishmentSubjectEntriesService	100%	100%
SAPPub.Core.Services.Performance.KS5EstablishmentSubjectEntriesService	100%
SAPPub.Core.Services.Performance.Level2QualificationsService	85.1%
SAPPub.Core.Services.Performance.Level3QualificationsService	100%	100%
SAPPub.Core.Services.Search.FeatureFlagSearchVisibilityPolicy	0%
SAPPub.Core.Specifications.SearchVisibilitySpecification	100%	100%
SAPPub.Core.ValueObjects.CodedDouble	100%
SAPPub.Core.ValueObjects.CodedString	100%

SAPPub.Infrastructure - 55.5%

Name	Line	Branch
SAPPub.Infrastructure	55.5%	22.9%
SAPPub.Infrastructure.Mapping.ValueCodes.CodedDoubleTypeHandler	9%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.CodedStringTypeHandler	10%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.ReasonCodeLookup	50%
SAPPub.Infrastructure.Mapping.ValueCodes.ReflectionCodedValueMapper	0%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.ValueCodeParser	0%	0%
SAPPub.Infrastructure.PostcodeLookup.PostcodeLookupService	100%
SAPPub.Infrastructure.PostgresSearch.PostgresSchoolSearchIndexReader	100%
SAPPub.Infrastructure.Repositories.Destinations.KS4DestinationsRepository	0%
SAPPub.Infrastructure.Repositories.EmailRepository	94.1%
SAPPub.Infrastructure.Repositories.EstablishmentRepository	100%	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayLocalAuthorityRepository	100%	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayUserAuditRepository	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayUserRepository	100%
SAPPub.Infrastructure.Repositories.Generic.DapperCommandBuilder	0%	0%
SAPPub.Infrastructure.Repositories.Generic.DapperRepository`1	90%	100%
SAPPub.Infrastructure.Repositories.Generic.JSONRepository`1	0%	0%
SAPPub.Infrastructure.Repositories.Helpers.DapperHelpers	60.2%	0%
SAPPub.Infrastructure.Repositories.KS4.Absence.EnglandAbsenceRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Absence.EstablishmentAbsenceReposito ry	100%
SAPPub.Infrastructure.Repositories.KS4.Absence.LAAbsenceRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.EnglandPerformanceReposi tory	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.EstablishmentPerformance Repository	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.LAPerformanceRepository	100%
SAPPub.Infrastructure.Repositories.LaUrlsRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS2PerformanceRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS4EstablishmentSubjectEntri esRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS5EstablishmentSubjectEntri esRepository	100%
SAPPub.Infrastructure.Repositories.Performance.KS5PerformanceRepository	100%

SAPPub.Web - 88.9%

Name	Line	Branch
SAPPub.Web	88.9%	82.2%
SAPPub.Web.Areas.Compare.Controllers.SecondaryController	100%
SAPPub.Web.Areas.Compare.Filters.SecondaryComparisonQueryValidationAttribut e	0%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareAboutYourSchoolsViewMo del	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareAcademicPerformanceEng lishAndMathsResultsViewModel	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareAcademicPerformancePup ilAttainmentViewModel	100%	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareDestinationsViewModel	100%	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareNextStepsViewModel	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareSecondarySchoolBaseVie wModel	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.SchoolAttainmentDetailsViewMo del	100%	100%
SAPPub.Web.Areas.Gateway.Controllers.GatewayController	53%	50%
SAPPub.Web.Areas.Profiles.Controllers.AboutController	100%
SAPPub.Web.Areas.Profiles.Controllers.AdmissionsController	100%
SAPPub.Web.Areas.Profiles.Controllers.CurriculumController	100%
SAPPub.Web.Areas.Profiles.Controllers.DestinationsController	100%
SAPPub.Web.Areas.Profiles.Controllers.KS2Controller	100%
SAPPub.Web.Areas.Profiles.Controllers.KS4Controller	100%
SAPPub.Web.Areas.Profiles.Controllers.KS5Controller	52.6%
SAPPub.Web.Areas.Profiles.Filters.DfEAnalyticsAddPhaseTagFilter	0%
SAPPub.Web.Areas.Profiles.Filters.PrimaryQueryValidationFilter	0%
SAPPub.Web.Areas.Profiles.Helpers.AcademicYearSelectionExtensions	94.4%	100%
SAPPub.Web.Areas.Profiles.Helpers.GcseGradeSelectionExtensions	64.2%	50%
SAPPub.Web.Areas.Profiles.ViewModels.AboutSchool.AboutSchoolViewModel	100%	100%
SAPPub.Web.Areas.Profiles.ViewModels.Admissions.AdmissionsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.Attendance.AttendanceViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.Destinations.KS4DestinationsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.Destinations.KS5DestinationsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformanceAdditionalMeasu resViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformanceMeetingOrExceed ingStandardsViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformancePupilProgressVi ewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.AcademicPerformanceSubjectScaledSc oresViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS2.CurriculumAndExtraCurricularActivi tiesViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS4.AcademicPerformanceAttainmentAndPr ogressViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS4.AcademicPerformanceSubjectsEntered ViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS4.CurriculumAndExtraCurricularActivi tiesViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.AdditionalDataViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.AverageResultViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.EnglishMathsQualificationsViewMode l	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.EnglishMathsScoreViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.Ks5SubjectEnteredViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.KS5ViewModel	0%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.Level2QualificationViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.Level3QualificationViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.KS5.ProgressScoreViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.ProfileBaseViewModel	100%	100%
SAPPub.Web.Areas.Profiles.ViewModels.SimpleCodedDoubleTableViewModel	100%
SAPPub.Web.Areas.Profiles.ViewModels.SubjectsEnteredBaseModel	66.6%
SAPPub.Web.Constants.Constants	100%
SAPPub.Web.Controllers.CookiesController	90.4%	100%
SAPPub.Web.Controllers.ErrorController	82.3%	100%
SAPPub.Web.Controllers.HealthController	67.5%	100%
SAPPub.Web.Controllers.HelpController	100%
SAPPub.Web.Controllers.HomeController	100%
SAPPub.Web.Controllers.MySchoolsController	100%	100%
SAPPub.Web.Controllers.MySchoolsListController	100%	100%
SAPPub.Web.Controllers.SchoolController	0%
SAPPub.Web.Controllers.SearchController	100%	100%
SAPPub.Web.Extensions.HttpContextExtensions	0%	0%
SAPPub.Web.Helpers.AttainmentHelper	98.3%	100%
SAPPub.Web.Helpers.CommonHelper	100%	100%
SAPPub.Web.Helpers.DisplayField`1	67.6%	50%
SAPPub.Web.Helpers.DisplayFieldExtensions	100%	100%
SAPPub.Web.Helpers.EnumHelper	100%
SAPPub.Web.Helpers.ProgressBandingHelper	77.7%
SAPPub.Web.Helpers.TempDataHelper	100%	100%
SAPPub.Web.Helpers.UrlHelper	100%	100%
SAPPub.Web.Middleware.DependenciesExtensions	100%	100%
SAPPub.Web.Middleware.GatewayMiddleware	100%	100%
SAPPub.Web.Middleware.GatewayMiddlewareExtensions	0%
SAPPub.Web.Middleware.NotFoundExceptionHandler	50%	50%
SAPPub.Web.Middleware.SecurityHeadersMiddleware	89.1%
SAPPub.Web.Middleware.SecurityHeadersMiddlewareExtensions	100%
SAPPub.Web.Models.BaseViewModel	80%	100%
SAPPub.Web.Models.Common.PagerViewModel	62%	100%
SAPPub.Web.Models.Common.PaginationItem	85.7%
SAPPub.Web.Models.ErrorViewModel	0%
SAPPub.Web.Models.MySchools.MySchoolModel	100%
SAPPub.Web.Models.MySchools.MySchoolsListViewModel	100%
SAPPub.Web.Models.MySchools.RemoveSchoolViewModel	100%
SAPPub.Web.Models.Search.SearchResult	100%	100%
SAPPub.Web.Models.Search.SearchResultsViewModel	100%	100%
SAPPub.Web.Models.SecondarySchool.AcademicPerformanceAdditionalMeasuresView Model	100%
SAPPub.Web.Models.SecondarySchool.AcademicPerformanceEnglishAndMathsResults ViewModel	100%
SAPPub.Web.Models.SecondarySchool.SuccessorOrPredecessorDetailsModel	100%
SAPPub.Web.ViewComponents.Banner.Banner	100%
SAPPub.Web.ViewComponents.ChartWithTableToggle.ChartWithTableToggle	100%
SAPPub.Web.ViewComponents.MySchools.AddSchoolButton	100%
SAPPub.Web.ViewComponents.Pagination.Pagination	100%
SAPPub.Web.ViewComponents.VerticalNavigation.VerticalNavigation	100%
SAPPub.Web.ViewComponents.VerticalNavigation.VerticalNavigationModel	50%	0%
SAPPub.Web.ViewComponents.VerticalNavigationCompareSecondary.VerticalNaviga tionCompareSecondary	100%
SAPPub.Web.ViewComponents.VerticalNavigationCompareSecondary.VerticalNaviga tionCompareSecondaryModel	0%	0%
SAPPub.Web.ViewComponents.VerticalNavigationMySchools.VerticalNavigationMyS chools	100%
SAPSec.Web.Setup.WebApplicationBuilderExtensions	33.8%	12.5%

github-actions · 2026-08-18T12:58:33Z

No critical or severe accessibility issues found

naomitodd added 3 commits August 14, 2026 16:38

Add primary school features section

0f88914

Add details section

fb4909b

Add feature flag for primary features on about page - as per ticket

adbda89

in view only to keep it simple

naomitodd added deploy A Review App will be created for PRs with this label refresh data The data pipeline will run as part of this deployment. labels Aug 17, 2026

naomitodd temporarily deployed to review August 17, 2026 13:42 — with GitHub Actions Inactive

naomitodd temporarily deployed to review August 17, 2026 13:45 — with GitHub Actions Inactive

naomitodd added 5 commits August 17, 2026 16:27

add page tests for feature flag - default to true to not break existi…

a935604

…ng tests, only set if needed

tidy up tests into folders

a9225ee

Move feature flag for subnav back into view & add asmissions page tes…

d59b62f

…ts - fix bug with vertical nav TODO curriculum page tests

fix navigation curriculum bug & update & fix tests

0fd3217

merge in main

da3034f

naomitodd temporarily deployed to review August 18, 2026 10:47 — with GitHub Actions Inactive

naomitodd temporarily deployed to review August 18, 2026 10:49 — with GitHub Actions Inactive

remove unused page url

9bd0213

naomitodd deployed to review August 18, 2026 12:58 — with GitHub Actions View deployment

naomitodd temporarily deployed to review August 18, 2026 13:00 — with GitHub Actions Inactive

naomitodd marked this pull request as ready for review August 18, 2026 13:53

stuw-dfe approved these changes Aug 18, 2026

View reviewed changes

naomitodd merged commit c1ff5fb into main Aug 18, 2026
14 checks passed

naomitodd deleted the feature/602-add-primary-school-features branch August 18, 2026 15:24

naomitodd temporarily deployed to review August 18, 2026 15:24 — with GitHub Actions Inactive

Navigation Menu

Uh oh!

Feature/602 add primary school features - #475

Feature/602 add primary school features#475
naomitodd merged 9 commits into
mainfrom
feature/602-add-primary-school-features

naomitodd commented Aug 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

naomitodd commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Uh oh!

github-actions Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026

Summary

Coverage

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

naomitodd commented Aug 17, 2026 •

edited

Loading

github-actions Bot commented Aug 17, 2026 •

edited

Loading