Skip to content

Add new version of countries data. - #166

Merged
mysteryGarlicPress merged 5 commits into
mainfrom
fcdo-countries
Aug 5, 2026
Merged

Add new version of countries data.#166
mysteryGarlicPress merged 5 commits into
mainfrom
fcdo-countries

Conversation

@mysteryGarlicPress

Copy link
Copy Markdown
Contributor

No description provided.

@asatwal asatwal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be any specs for this, even if they are minimal ?

@mysteryGarlicPress mysteryGarlicPress changed the title Add FCDO country list Add new version of countries data. Aug 3, 2026

@asatwal asatwal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review comments.

Comment thread spec/support/autocomplete.rb
Comment thread spec/support/autocomplete.rb
Comment thread raw_data/FCDO_Geographical_Names_Index_September_2025.csv
Comment thread raw_data/FCDO_Geographical_Names_Index_September_2025.csv Outdated
Comment thread lib/dfe/reference_data/helpers/v2/country_list_compiler.rb Outdated
Comment thread docs/decisions/0004-versioning.md Outdated
Comment thread docs/lists_countries_and_territories.md
Comment thread spec/lib/dfe/reference_data/v2/countries_and_territories_spec.rb
Comment thread lib/dfe/reference_data/helpers/v2/country_list_compiler.rb
Comment thread docs/lists_countries_and_territories.md Outdated

@asatwal asatwal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming most of the important comments have been addressed.

@mysteryGarlicPress
mysteryGarlicPress merged commit 0e3c4db into main Aug 5, 2026
2 checks passed
@mysteryGarlicPress
mysteryGarlicPress deleted the fcdo-countries branch August 5, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants