fix(simulator): default to mainnet instead of forcing testnet#1
Open
moralpriest wants to merge 2 commits intoDEROFDN:community-devfrom
Open
fix(simulator): default to mainnet instead of forcing testnet#1moralpriest wants to merge 2 commits intoDEROFDN:community-devfrom
moralpriest wants to merge 2 commits intoDEROFDN:community-devfrom
Conversation
moralpriest
force-pushed
the
fix/simulator-mainnet-default
branch
3 times, most recently
from
b32291d to
7aace61
Compare
Previously, the simulator hardcoded --testnet=true, preventing users from testing mainnet behavior. The simulator would always run in testnet mode regardless of user input. This change: - Removes the hardcoded --testnet=true assignment - Defaults to mainnet when --testnet flag is not provided - Properly respects the --testnet flag when explicitly set by user - Adds defensive nil checking in InitNetwork() to handle missing flag Fixes simulator network mode selection to match user expectations.
moralpriest
force-pushed
the
fix/simulator-mainnet-default
branch
from
7aace61 to
6912199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the simulator to default to mainnet mode instead of forcing testnet mode. The --testnet flag is now respected when provided by the user.
Previously, the simulator hardcoded --testnet=true, preventing users from testing mainnet behavior. This change allows the simulator to default to mainnet while still respecting the --testnet flag when explicitly provided.
Type of change
Which part is impacted ?
Checklist:
License
I am contributing & releasing the code under DERO Research License (which can be found here).