Implement better command line argument parsing for main.cpp using Boost #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is necessary to verify on the file requested is available and within the specific data/ directory. This change ensures that communication refers to filenames, and all file access will be resolved against the data directory. Additionally, a regex check ensures that arbituary file fetches fail.
FTP Cleanup
[FTP-2] FTP File Resolution/Verification
* added ftp bug fix * added path library fix for macos with bazelrc change * close conn * fixed subtask division
This reverts commit 173f8cf.
This reverts commit c1a5ffa.
* added build files * updated build
* added build files * updated build * proto files * updated ip address
* added build files * updated build * proto files * updated ip address * header files * updated includes for utility func
* added build files * updated build * proto files * updated ip address * header files * updated includes for utility func * serialization, deserialization code * updated to use ip address proto
* added build files * updated build * proto files * updated ip address * header files * updated includes for utility func * serialization, deserialization code * updated to use ip address proto * logic code * updated utility func
Co-authored-by: Rayaq Siddiqui <[email protected]> Co-authored-by: Jordan Mao <[email protected]> Co-authored-by: Wuyue (Tony) Sun <[email protected]>
Notable changes aside from small bugs: - Peer to peer server/client C++ messages are preceded by message sizes (uint_32) to ensure enough buffer size is allocated for the message data. Previously, fixed buffer sizes of 1024 bytes were used, which truncated larger protobuf messages. - ZMQ requests must be followed with a reply when using the REQ-REP model - Message protobuf serialization into strings was missing braces around case blocks, and some blocks did not have the corresponding protobuf subtypes allocated.
[ML Integration] Integration Branch Combining C++ and Python Work
Modifications to allow P2P over Tailscale
* temp changes * changes made Co-authored-by: Wuyue (Tony) Sun <[email protected]> Co-authored-by: Rayaq Siddiqui <[email protected]> * fix build errors * completed multiple iterations code Co-authored-by: Jordan Mao <[email protected]> Co-authored-by: Joon Kang <[email protected]> Co-authored-by: Wuyue (Tony) Sun <[email protected]> Co-authored-by: Rayaq Siddiqui <[email protected]> * small bug fixes --------- Co-authored-by: jordanmao <[email protected]> Co-authored-by: Wuyue (Tony) Sun <[email protected]> Co-authored-by: Rayaq Siddiqui <[email protected]> Co-authored-by: Joon Kang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow user to specify specific arguments in more flexible, intuitive way:
