Add notifications to IRCops when they get restricted information.#171
Open
jfcantu wants to merge 3 commits intoDALnet:masterfrom
Open
Add notifications to IRCops when they get restricted information.#171jfcantu wants to merge 3 commits intoDALnet:masterfrom
jfcantu wants to merge 3 commits intoDALnet:masterfrom
Conversation
…re/oper-only-info-notifications
Member
Author
|
(FYI - the XFLAG part of this needs testing by someone with DALnet services.) |
kobishmueli
reviewed
Jul 22, 2020
| sendto_one(sptr, ":%s %d %s %s :%s", me.name, servicestag->raw, parv[0], name, servicestag->tag); | ||
| /* Otherwise, it can only be viewed by users with the correct umode (usually +o or higher) */ | ||
| else if(sptr->umode & servicestag->umode) | ||
| sendto_one(sptr, ":%s %d %s %s :%s [IRCop Restricted Information]", me.name, servicestag->raw, parv[0], name, servicestag->tag); |
Member
There was a problem hiding this comment.
This is problematic and conflicts with our current SVSTAG usage.
Kobi.
Contributor
|
Per discussion in #operators, please hold on this one for now. Thank you for jumping on it and the initiative -- we just need to all discuss how to consistently handle this across services replies and ircd replies. There are some admin-only responses to consider (which would be marked admin-only instead of oper-only), which may include SVSTAGS. So let's keep this open to discuss as a low-priority item. |
rscs
requested changes
Sep 11, 2020
Contributor
rscs
left a comment
rscs
left a comment
There was a problem hiding this comment.
This needs more discussion per my note on July 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #141.
Warn IRCops that normal users can't see what they're seeing, when they get:
RPL_WHOISACTUALLY)RPL_WHOISTEXT)XFLAG_HIDE_MODE_LISTSis set.