Skip to content

Rebuild site: nav bar, light/dark mode, new favicon, asset cleanup - #2

Merged
D4DavidG merged 1 commit into
mainfrom
site-refresh
Aug 9, 2026
Merged

D4DavidG merged 1 commit into
mainfrom
site-refresh

Conversation

@D4DavidG

@D4DavidG D4DavidG commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Stylesheet

  • Consolidate styles.css: drop dead rules (.project-header, .fitness-functions, .pocket-professors) and fold the accreted "FIX 1-4" override block into the rules it was patching; header.glass was declared three times.
  • Remove the --neon alias. It was declared as --neon: var(--accent) on :root, so it resolved against the :root accent and ignored the per-page theme, leaving aqua/gold pages with green headings, links and outlines.

Nav

  • Replace the top nav pill row with a fixed horizontal bar: icon above label, evenly spaced, collapsing to small icons only while scrolling down.
  • Inline SVG icons for every section on all four pages, plus a DG logo item linking to the top of the page.

Light / dark mode

  • Add a mode toggle at the end of the bar; persists to localStorage and falls back to prefers-color-scheme. A tiny inline head script applies the mode before first paint so the page cannot flash.
  • Split the accent into --accent (glow/fill) and --accent-ink (text). The neon accents measure ~1.3:1 on a light panel, so links and headings use a darkened per-theme ink. All text now clears WCAG AA in both modes.
  • Parameterise the grid, vignette and cursor glow; screen blending only brightens, so light mode multiplies a darker halo instead.

Assets

  • Regenerate the favicon set from the DG logo with a transparent background; trim the head from five icon links to three.
  • Convert screenshots and the profile photo to WebP with dimensions and lazy loading (5.8 MB -> 810 KB), and delete the superseded originals.

Fixes

  • Extract the mouse-glow IIFE and year script into a shared main.js; the contact manager page had registered two competing scroll listeners.
  • Correct the self-referential "Back to Resume" link on the resume page.

Stylesheet
- Consolidate styles.css: drop dead rules (.project-header, .fitness-functions,
  .pocket-professors) and fold the accreted "FIX 1-4" override block into the
  rules it was patching; header.glass was declared three times.
- Remove the --neon alias. It was declared as `--neon: var(--accent)` on :root,
  so it resolved against the :root accent and ignored the per-page theme,
  leaving aqua/gold pages with green headings, links and outlines.

Nav
- Replace the top nav pill row with a fixed horizontal bar: icon above label,
  evenly spaced, collapsing to small icons only while scrolling down.
- Inline SVG icons for every section on all four pages, plus a DG logo item
  linking to the top of the page.

Light / dark mode
- Add a mode toggle at the end of the bar; persists to localStorage and falls
  back to prefers-color-scheme. A tiny inline head script applies the mode
  before first paint so the page cannot flash.
- Split the accent into --accent (glow/fill) and --accent-ink (text). The neon
  accents measure ~1.3:1 on a light panel, so links and headings use a darkened
  per-theme ink. All text now clears WCAG AA in both modes.
- Parameterise the grid, vignette and cursor glow; `screen` blending only
  brightens, so light mode multiplies a darker halo instead.

Assets
- Regenerate the favicon set from the DG logo with a transparent background;
  trim the head from five icon links to three.
- Convert screenshots and the profile photo to WebP with dimensions and lazy
  loading (5.8 MB -> 810 KB), and delete the superseded originals.

Fixes
- Extract the mouse-glow IIFE and year script into a shared main.js; the
  contact manager page had registered two competing scroll listeners.
- Correct the self-referential "Back to Resume" link on the resume page.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 9, 2026 00:04
@D4DavidG
D4DavidG merged commit 092bdd2 into main Aug 9, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR rebuilds the site’s shared UI and styling: it consolidates and retokens styles.css, replaces the old top “pill” navigation with a fixed icon+label nav bar, and introduces a persistent light/dark mode that applies before first paint to avoid flashing.

Changes:

  • Refactors styles.css into dark/light design tokens and per-page accent themes, and cleans up dead/duplicated rules.
  • Adds a fixed top nav bar (collapsing on scroll) with inline SVG icons and updated in-page anchors.
  • Introduces shared main.js for year, mode toggle persistence, nav collapse behavior, and cursor glow tracking; updates assets (favicons + WebP images).

Reviewed changes

Copilot reviewed 6 out of 54 changed files in this pull request and generated no comments.

Show a summary per file
File Description
styles.css Consolidates styling into tokenized dark/light modes, new accent system, fixed nav bar styling, and cleaned-up/removed legacy overrides.
main.js Adds shared JS for year rendering, persisted light/dark toggle, scroll-driven nav collapse, and cursor glow variables.
index.html Adopts the new fixed nav bar + mode bootstrapping script, switches profile image to WebP, and removes old inline scripts/nav.
fitnessfunctions.html Adds the new nav bar + mode bootstrapping script, updates section anchors, and converts screenshots to WebP with performance-friendly attributes.
project-contact-manager.html Adds the new nav bar + mode bootstrapping script, updates anchors, converts screenshot to WebP, and removes duplicated inline scripts.
project-pocketprofessors.html Adds the new nav bar + mode bootstrapping script, updates anchors, converts screenshots to WebP, and fixes the “Back to Resume” breadcrumb target.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants