New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ABI encoding comments and refactor ERC20 Metadata #329

Merged

t4sk merged 3 commits into Cyfrin:gh-pages from Pronoss:fix/update

Mar 31, 2025

Contributor

Pronoss commented Mar 19, 2025

✅ AbiEncode.sol

Clarified inline comments explaining the behavior of abi.encodeWithSignature and abi.encodeWithSelector.
Replaced misleading comments about typo checking to avoid confusion.

✅ index.html.ts (abi-encode)

Updated HTML comments to better explain how ABI encoding works and the lack of compile-time checks.

✅ index.html.ts (erc20)

Refactored metadata:
- Updated the title for better context.
- Enhanced the description.
- Expanded keywords to improve discoverability (added "mint", "burn", "token swap", "dapp").

Pronoss added 3 commits

March 19, 2025 17:48


          Update AbiEncode.sol


          Update index.html.ts

63d47cb


          Update index.html.ts

82b830c

t4sk merged commit 059897c into Cyfrin:gh-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet