MLE implementation #120
Open
MLE implementation #120
+173
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaubansa
reviewed
Feb 7, 2025
| @log_obj.logger.error(ExceptionHandler.new.new_api_exception err) | ||
| raise err | ||
| end | ||
| if [email protected]? && [email protected]_a?(Hash) |
There was a problem hiding this comment.
check for Map value type should be <String,Boolean>
gaubansa
reviewed
Feb 7, 2025
| if is_mle_supported_by_cybs_for_api && merchant_config.useMLEGlobally | ||
| is_mle_for_api = true | ||
| end | ||
| if merchant_config.mapToControlMLEonAPI.nil? && merchant_config.mapToControlMLEonAPI.nil? |
There was a problem hiding this comment.
why same condition check for 2 times?
gaubansa
reviewed
Feb 7, 2025
| certificate = get_certificate(merchant_config, @log_obj) | ||
| validate_certificate(certificate, merchant_config, @log_obj) | ||
| serial_number = extract_serial_number_from_certificate(certificate) | ||
| if serial_number.nil? |
There was a problem hiding this comment.
if serial number is null then we can put default serial number from cert as same as implemented in Java.
gaubansa
reviewed
Feb 7, 2025
| end | ||
| end | ||
|
|
||
| def validate_certificate(certificate, merchant_config, log_obj) |
There was a problem hiding this comment.
don't pass merchant_config, pass only required parameter such as key_alias. IF it is generic function then try to put in certificate utility if available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.