refactor(storage): extract local worker storage adapter (#1243) - #1452
Merged
Conversation
jlon
approved these changes
Jul 31, 2026
jlon
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the worker local storage implementation into a new
curvine-storage-localadapter crate while preserving the existing local block storage behavior.curvine-servernow depends on the adapter and keeps the existing worker storage and block metadata paths available through re-exports.Issue Describe / Design
Related to #1243
Design notes:
crates/adapters/curvine-storage-local.Cargo.toml,lib.rs, workspace membership, andcurvine-serverdependency wiring.curvine-storage-local/spdk; no new SPDK or RDMA link path was added.curvine-serverimport surface with re-exports so runtime behavior remains unchanged.Changes
crates/adapters/curvine-storage-localCargo.toml,Cargo.lockcurvine-server/Cargo.tomlcurvine-storage-localand forwarded storage-local SPDK features.curvine-server/src/worker/mod.rscurvine_storage_localasworker::storage.curvine-server/src/worker/block/mod.rsBlockMetaandBlockStatefrom the new adapter crate.Test verified
make formatcargo check -p curvine-storage-localcargo check -p curvine-servercargo test -p curvine-storage-localcargo test -p curvine-server worker::block::block_storeDependencies