Add strict subvariable syntax handler #465
Conversation
scrunch/scripts.py
Outdated
| def format_request_url(self, execute, strict_subvariable_syntax=None): | ||
| strict_subvariable_syntax_flag = self.get_default_syntax_flag(strict_subvariable_syntax) | ||
| if strict_subvariable_syntax_flag: | ||
| execute.self += "?strict_subvariable_syntax=true" |
There was a problem hiding this comment.
Here you will be mutating the self attribute of the execute resource. I think that this better returns the desired URL instead of altering the instance.
Because when you execute a script for the 2nd time this will add again this string incorrectly
There was a problem hiding this comment.
That is not completely true. I am not mutating the self.resource instance, but just the local execute.
Every time you do self.resource.something there is a GET call to the resource o get the attribute.
So the self.resource instance is not modified by this, I am just updating the local object that is the result of the GET
So here
Line 73 in 86b3b73
execute object, and I am modifing this one that is the result of this call https://github.com/Crunch-io/pycrunch/blob/9bb073368293f1e84843a53bdc0cfccd1c90787e/src/pycrunch/elements.py#L154Next time, next script, I am going to redo the request to the same self.resource object, that has not being modified.
Let me know if that works for you. Otherwise I'll think of another way of doing this. But I just wanted to use the pycrunch interface as per the DatasetsScripts
scrunch/scripts.py
Outdated
| try: | ||
| execute = self.resource.execute | ||
| self.format_request_url(execute, strict_subvariable_syntax) | ||
| return execute.post(payload) |
There was a problem hiding this comment.
I see why you had to mutate the instance, I think that here it's best to use a raw request, see how this pycrunch .post() is implemented and you'll do a self.resource.session.post(execute_url. ....).
There was a problem hiding this comment.
As explained above, I did not mutate the instance, so we should be safe
Add
strict_subvariable_syntaxflag handler for system script + tests