Skip to content

fix(multiselect): scope chevron clicks to the correct container #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryan-nauman-cs
Copy link

@ryan-nauman-cs ryan-nauman-cs commented Jun 9, 2025

Pull Request Template

🚀 Description

This PR fixes an issue with multiple multiselect components on the same page. Previously, when clicking on a multiselect container, the code would use document.querySelector to find the input element, which could incorrectly target the first multiselect on the page rather than the one that was clicked.

The fix modifies the handleContainerClick method to:

  • Accept a MouseEvent parameter
  • Use the event's currentTarget to scope the querySelector to the specific container that was clicked
  • This ensures each multiselect component correctly focuses its own input when clicked

Added a comprehensive test case that verifies multiple multiselect components work correctly when placed on the same page.


🔬 How to Test

  1. Add multiple multiselect components to a page
  2. Click on each multiselect container
  3. Verify that the correct popover opens for the clicked multiselect
  4. Verify that the input for the clicked multiselect receives focus
  5. Run the new test case to confirm the fix works as expected

📸 Images/Videos of Functionality

No visual changes to the component's appearance - this is a behavioral fix that ensures the correct multiselect responds when clicked. Here's a before & after of the docs that show the bad behavior.

before.mp4
after.mp4

Copy link

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: 3a5153c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant