fix: set value attribute on textarea instead of in content to ensure value and defaultValue stay in sync with changes

[kmillns]

🚀 Description

Fixes issue #446 where the underlying <textarea> used in Form::Controls::Textarea gets out of sync with @value changes after typing in the <textarea>.

Also adds tests for both current working functionality of updating value before typing in the textarea and the previously broken case of typing in the textarea and then attempting an update of the value from outside the component.

---

🔬 How to Test

Added test cases should cover the functionality changing.

There's no external impact on existing examples to show.

Reversing the change in textarea.gts should result in one failed test case for the issue described in #446

[changeset-bot]

🦋 Changeset detected

Latest commit: 34df8d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@crowdstrike/ember-toucan-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nicolechung]

Thank you for making this fix 🚀

[nicolechung]

@kmillns I'm a little confused as I am unable to re-create the error problem over here: https://ember-toucan-core.pages.dev/docs/components/textarea

But your code and test look correct to me, so I've approved.

[kmillns]

@kmillns I'm a little confused as I am unable to re-create the error problem over here: https://ember-toucan-core.pages.dev/docs/components/textarea

But your code and test look correct to me, so I've approved.

Yeah, I don't think it's something that would normally happen with just typing in the <textarea> but instead is the combination of typing, which causes the underlying <textarea> to use .value instead of .defaultValue and then triggering a change in the @value, which is essentially just changing the .defaultValue.

These screenshots show how .value and .defaultValue (initially both '' in the demo) get out of sync after typing in the <textarea>, and the @value being inside only updates the .defaultValue so it will only appear out of sync if trying to update after typing.

[ynotdraw]

@simonihmig I can't recall exactly why we did this initially. Do you?

[ynotdraw]

Looks good to me. Let's see if @simonihmig remembers about the value change above to make sure we don't have a potential issue before merging! Thanks!

[ynotdraw]

@kmillns I kicked off CI and looks like a few linting/TS errors

[kmillns]

Everything looks green except cloudflare publish which I think is unrelated to this PR:

Error: Input required and not supplied: apiToken

[ynotdraw]

Everything looks green except cloudflare publish which I think is unrelated to this PR:

Error: Input required and not supplied: apiToken

Yeah, that'll fail since you aren't in the org. Only outstanding thing to me is #447 (review). @simonihmig do you recall?