Adding bazelmod #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gittiver merged 8 commits into CrowCpp:master from sebastianbergt:adding-bazelmod

May 29, 2025

sebastianbergt commented Mar 12, 2025 •

edited

Loading

Hi,

would you accept a bazel module in your code?
I am trying to add CrowCpp to bazel registry and hence did the work anyway.
Also, if you are interested, I can add the test to the bazel build.

Sebastian Bergt added 2 commits

March 12, 2025 21:37


          adding bazelmod

e51c798


          adding a CI build

7b2d2a2

gittiver marked this pull request as draft

March 13, 2025 07:46

Member

gittiver commented Mar 13, 2025 •

edited

Loading

bazel build does not work on macOs, I put it back into draft.

gittiver reviewed

View reviewed changes

MODULE.bazel Outdated Show resolved Hide resolved

gittiver reviewed

View reviewed changes

.github/workflows/build_bazel.yml Outdated Show resolved Hide resolved

gittiver reviewed

View reviewed changes

.github/workflows/build_bazel.yml Outdated Show resolved Hide resolved

gittiver reviewed

View reviewed changes

.github/workflows/build_bazel.yml Outdated Show resolved Hide resolved

gittiver reviewed

View reviewed changes

BUILD.bazel Outdated Show resolved Hide resolved

Sebastian Bergt added 2 commits

March 29, 2025 09:32


          keeping bazel local and adding options for compression and ssl

d0e27d0


          mend

e636917

Author

sebastianbergt commented Mar 29, 2025 •

edited

Loading

bazel build does not work on macOs, I put it back into draft.

Thank you for the quick review and detailled feedback :)

sebastianbergt requested a review from gittiver

March 29, 2025 08:38

Sebastian Bergt added 2 commits

March 29, 2025 09:59


          adding ssltest

ca9b640


          build and test in CI

7bf4cdc

Member

gittiver commented Mar 31, 2025

There is a problem on macOS.

gittiver requested changes

View reviewed changes

Member

gittiver left a comment

set back to Draft as it does not build on MacOS 13


          remove mac os from bazel build

ed87e80

Author

sebastianbergt commented May 22, 2025

set back to Draft as it does not build on MacOS 13

Hei @gittiver
sorry for the delay. I sadly had to remove mac-os from the list of tested systems,
since dependencies are not compiling on it.

sebastianbergt marked this pull request as ready for review

May 22, 2025 09:48

sebastianbergt requested a review from gittiver

May 22, 2025 09:49


          Removed ubuntu20.04 from build matrix

292d56e

its not supported by github anymore

gittiver approved these changes

View reviewed changes

gittiver approved these changes

View reviewed changes

gittiver merged commit bf4ac33 into CrowCpp:master

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet