Feature/new tokens node #49
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| { name: 'Ukrainian (Ukraine)', value: 'uk-UA' }, | ||
| { name: 'Thai (Thailand)', value: 'th-TH' }, | ||
| { name: 'Vietnamese (Vietnam)', value: 'vi-VN' }, | ||
| { name: 'Klingon', value: 'Klingon' }, |
There was a problem hiding this comment.
style: Klingon locale option seems out of place among standard language locales
| if (!name || !image || !description) { | ||
| throw new NodeOperationError(context.getNode(), 'Name, Image, and Description are required for metadata object mode', { | ||
| itemIndex, | ||
| }); | ||
| } |
There was a problem hiding this comment.
style: Consider using the validateRequiredField utility function consistently instead of manual validation to match the pattern used elsewhere in the function
| if (attributesJson && attributesJson.trim() !== '') { | ||
| try { | ||
| const attributes = JSON.parse(attributesJson); | ||
| if (Array.isArray(attributes)) { | ||
| metadata.attributes = attributes; | ||
| } |
There was a problem hiding this comment.
logic: Silent failure when attributes is not an array - consider adding a warning or error message to inform users
| export function buildTokenRecipient( | ||
| recipientData: WalletLocatorData, | ||
| chain?: string, | ||
| context?: any, | ||
| itemIndex?: number | ||
| ): string { | ||
| if (recipientData.mode === 'address') { | ||
| const address = recipientData.value; | ||
| if (!address || address.trim() === '') { | ||
| throw new NodeOperationError(context?.getNode(), 'Wallet address is required', { | ||
| itemIndex, | ||
| }); | ||
| } | ||
|
|
||
| if (address.startsWith('0x')) { | ||
| return `polygon:${address}`; | ||
| } else { | ||
| return `solana:${address}`; | ||
| } | ||
| } else { | ||
| const value = recipientData.value; | ||
| if (!value || value.trim() === '') { | ||
| throw new NodeOperationError(context?.getNode(), 'Recipient value is required', { | ||
| itemIndex, | ||
| }); | ||
| } | ||
| return `${recipientData.mode}:${value}:${chain}`; | ||
| } | ||
| } | ||
|
|
||
| export function buildTokenWalletIdentifier( | ||
| walletIdentifierData: WalletLocatorData, | ||
| chain?: string, | ||
| context?: any, | ||
| itemIndex?: number | ||
| ): string { | ||
| if (walletIdentifierData.mode === 'address') { | ||
| const address = walletIdentifierData.value; | ||
| if (!address || address.trim() === '') { | ||
| throw new NodeOperationError(context?.getNode(), 'Wallet address is required', { | ||
| itemIndex, | ||
| }); | ||
| } | ||
|
|
||
| if (address.startsWith('0x')) { | ||
| return `polygon:${address}`; | ||
| } else { | ||
| return `solana:${address}`; | ||
| } | ||
| } else { | ||
| const value = walletIdentifierData.value; | ||
| if (!value || value.trim() === '') { | ||
| throw new NodeOperationError(context?.getNode(), 'Wallet identifier value is required', { | ||
| itemIndex, | ||
| }); | ||
| } | ||
| return `${walletIdentifierData.mode}:${value}:${chain}`; | ||
| } | ||
| } |
There was a problem hiding this comment.
style: Both functions contain nearly identical logic. Consider extracting common functionality to reduce code duplication.
| if (address.startsWith('0x')) { | ||
| return `polygon:${address}`; | ||
| } else { | ||
| return `solana:${address}`; | ||
| } |
There was a problem hiding this comment.
logic: Address format detection using startsWith('0x') is fragile. Consider using a more robust blockchain detection method or explicit chain parameter.
| export function buildTokenRecipient( | ||
| recipientData: WalletLocatorData, | ||
| chain?: string, | ||
| context?: any, |
There was a problem hiding this comment.
style: Inconsistent typing: context?: any differs from existing functions that use proper type casting. Should match the pattern on line 18.
| export interface TransferTokenRequest { | ||
| recipient: string; | ||
| amount: string; | ||
| amount?: string; |
There was a problem hiding this comment.
logic: Making amount optional is a breaking change. Ensure all consumers handle undefined amount appropriately to prevent runtime errors.
| console.log('API Request Failed:'); | ||
| console.log(JSON.stringify({ | ||
| endpoint, | ||
| requestBody, | ||
| apiVersion: API_VERSIONS.WALLETS, | ||
| }, null, 2)); |
There was a problem hiding this comment.
style: Debug console.log statements in production code - consider using proper logging or removing
| ): Promise<IDataObject> { | ||
| const tknChain = context.getNodeParameter('tknChain', itemIndex) as string; | ||
| const tknName = context.getNodeParameter('tknName', itemIndex) as string; | ||
| const blockchainType = context.getNodeParameter('blockchainType', itemIndex) as string; |
There was a problem hiding this comment.
logic: Missing validation for blockchainType parameter - other required parameters are validated but this one is not
| recipient: recipient, | ||
| }; | ||
|
|
||
|
|
There was a problem hiding this comment.
style: Extra blank line should be removed for consistency
| console.log('API Request Failed:'); | ||
| console.log(JSON.stringify({ | ||
| endpoint, | ||
| requestBody, | ||
| apiVersion: API_VERSIONS.WALLETS, | ||
| }, null, 2)); |
There was a problem hiding this comment.
style: Debug logging to console in production code - consider using proper logging mechanism or removing before production
| const responseParams = (rawResponse as IDataObject).params as { calls?: Array<{ chain?: string }> }; | ||
| if (responseParams && responseParams.calls && responseParams.calls[0]) { | ||
| chain = responseParams.calls[0].chain; | ||
| } |
There was a problem hiding this comment.
logic: Chain extraction logic uses unsafe array access - should check array length before accessing calls[0]
There was a problem hiding this comment.
I'm learning! Leave a 👍 or a 👎 to help me learn. Extra points if you leave a comment telling me why i'm wrong tagging @greptileai
1 file reviewed, no comments
1 participant
No description provided.