Skip to content

Conversation

@VeniaminC
Copy link
Contributor

@VeniaminC VeniaminC commented Jul 14, 2025

feat: deprecate Vue support

Summary

This PR completely removes Vue.js support from the crossmint-sdk repository by:

  • Removing Vue UI package: Deleted the entire packages/client/ui/vue-ui/ directory containing the Vue implementation of CrossmintPaymentElement
  • Removing Vue demo app: Deleted the apps/payments/vue/ directory containing the Vue payment demo application
  • Updating workspace configuration: Removed Vue UI package reference from crossmint-sdk.code-workspace
  • Cleaning dependencies: Updated pnpm-lock.yaml to remove Vue-related dependencies

A total of 28 files were deleted, removing 5,013 lines of Vue-specific code while preserving all React and Vanilla JS implementations.

Review & Testing Checklist for Human

  • Search for broken imports - Verify no other packages or apps import from @crossmint/client-sdk-vue-ui or reference the removed Vue components
  • Test build process - Run pnpm build:libs to ensure all remaining packages build successfully without the Vue dependencies
  • Verify workspace integrity - Confirm the workspace configuration changes don't break VS Code setup or development workflows
  • Test remaining UI packages - Verify that React UI (@crossmint/client-sdk-react-ui) and Vanilla UI (@crossmint/client-sdk-vanilla-ui) still function correctly
  • Check example apps - Test that other demo apps (React, Next.js) still work properly after Vue removal

Recommended test plan: Run the build process, test a few remaining demo applications, and search the codebase for any remaining Vue references to ensure clean removal.


Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    A["packages/client/ui/vue-ui/<br/>(entire directory)"]:::major-edit
    B["apps/payments/vue/<br/>(entire directory)"]:::major-edit
    C["crossmint-sdk.code-workspace"]:::minor-edit
    D["pnpm-lock.yaml"]:::minor-edit
    E["packages/client/ui/react-ui/"]:::context
    F["packages/client/ui/vanilla-ui/"]:::context
    G["apps/payments/react/"]:::context
    H["apps/payments/nextjs/"]:::context
    
    A -->|"DELETED"| D
    B -->|"DELETED"| D
    C -->|"Vue reference removed"| A
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF
Loading

Notes

  • This is part of a broader effort to deprecate Vue support across Crossmint repositories
  • Companion PR in crossbit-main repo removes Vue documentation examples
  • The build completed successfully after removal, indicating no immediate dependency issues
  • All other UI frameworks (React, Vanilla JS) remain fully supported and unchanged

Link to Devin run: https://app.devin.ai/sessions/9d3114e8b6f34cab8f2d9b7366fdda77
Requested by: @VeniaminC

- Remove Vue UI package from packages/client/ui/vue-ui/
- Remove Vue demo app from apps/payments/vue/
- Update workspace configuration to remove Vue references
- Clean up Vue dependencies from pnpm-lock.yaml

Co-Authored-By: Veniamin <[email protected]>
@devin-ai-integration
Copy link
Contributor

Original prompt from Veniamin:

Deprecate support for Vue.

- Remove all Vue-related code and dependencies from crossbit-main and crossmint-sdk

You only need to look in the following repos: Crossmint/crossmint-sdk, Paella-Labs/crossbit-main

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: a987dd0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
smart-wallet-auth-demo ⬜️ Ignored (Inspect) Jul 14, 2025 5:11am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants