Skip to content

Conversation

@alberto-crossmint
Copy link
Contributor

@alberto-crossmint alberto-crossmint commented Jun 25, 2025

Description

Extracting communications schemas to this common library so we can handled them in a centralized way

Test plan

It's just copied from the iframes repo, so nothing else. Will substitute this lib in both the iframe, the relayer and the tee and test e2e.

Package updates

@vercel
Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
smart-wallet-auth-demo ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2025 9:32pm

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2025

🦋 Changeset detected

Latest commit: b17194d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@crossmint/client-signers Patch
expo-demo Patch
@crossmint/client-sdk-react-base Patch
@crossmint/client-sdk-react-native-ui Patch
@crossmint/client-sdk-react-ui Patch
@crossmint/wallets-sdk Patch
@crossmint/auth-ssr-nextjs-demo Patch
@crossmint/client-sdk-react-ui-starter Patch
@crossmint/client-sdk-nextjs-starter Patch
@crossmint/wallets-quickstart-devkit Patch
@crossmint/client-sdk-smart-wallet-next-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alberto-crossmint alberto-crossmint enabled auto-merge (squash) June 25, 2025 21:33
Copy link
Contributor

@devlyn37 devlyn37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may actually want to go in the other direction. Open Signer is meant to be independent from Crossmint, and shouldn't depend on Crossmint specific packages. I'd propose we instead begin moving any Open Signer related pieces we need centralized (API & Iframe Event Schema, etc) to the Open Signer repository.

Details need refinement, but was thinking the end state should look something like:

  • We publish an open-signer/schema package from the Open Signer repository.
  • Crossmint's SDKs use this package to interface with the iframe.
  • Crossmint's relay uses this package and implements the relay endpoints according to the minimal schema defined in the package.

Not sure we'll prioritize this right away, but if we're aligned we should avoid moving in the opposite direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants