Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Remove Vue UI Package and All Related Code

This PR removes the @crossmint/client-sdk-vue-ui package and all related code from the crossmint-sdk repository as requested.

Changes Made

  • Deleted the entire packages/client/ui/vue-ui/ directory and all its contents
  • Updated workspace configuration in crossmint-sdk.code-workspace to remove Vue UI folder reference
  • Removed Vue UI dependency from Vue payments app package.json
  • Updated Vue components to use base package imports instead of Vue UI package
  • Replaced CrossmintPaymentElement component with simple iframe implementation
  • Cleaned up package dependencies and lockfile via pnpm install

Impact

The Vue payments demo app (apps/payments/vue/) now has simplified functionality:

  • Uses useCrossmintEvents directly from @crossmint/client-sdk-base instead of the Vue UI package
  • Replaces the Vue-specific CrossmintPaymentElement with a basic iframe
  • Maintains basic integration demonstration capabilities

Test plan

  • ✅ Verified pnpm build:libs completes successfully after removal
  • ✅ Verified pnpm lint passes with no errors
  • ✅ Confirmed all Vue UI package references removed from workspace configuration
  • ✅ Confirmed all imports updated to use base package
  • ✅ Searched codebase to ensure no remaining active references to @crossmint/client-sdk-vue-ui
  • ✅ Verified package dependencies cleaned up in lockfile

The build system continues to work correctly and all packages compile without the removed Vue UI package.

Link to Devin run

https://app.devin.ai/sessions/2894883aaa854230a67bf372ab8e35e3

Requested by: julio ([email protected])

- Deleted packages/client/ui/vue-ui/ directory completely
- Removed Vue UI reference from workspace configuration
- Updated Vue payments app to remove Vue UI dependency
- Replaced CrossmintPaymentElement with simple iframe
- Updated imports to use base package directly
- Cleaned up package dependencies and lockfile

Co-Authored-By: julio <[email protected]>
@devin-ai-integration
Copy link
Contributor Author

Original prompt from julio:

Received message in Slack channel #team-infra:

@Devin, remove the package at the "packages/client/ui/vue-ui" path and all related code from our crossmint-sdk repo.

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: d67d7a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
smart-wallet-auth-demo ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2025 9:48am

@juliojordan juliojordan marked this pull request as draft June 23, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants