Skip to content

Fix Slippage Math + Sanity Checks (swap.js) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MithrandirBalrog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Slippage Math + Sanity Checks (swap.js) #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clawlett/scripts/swap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ function parseArgs() {
case '--config-dir':
case '-c':
result.configDir = args[++i]
if (!Number.isFinite(args.slippage) || args.slippage <= 0 || args.slippage > 0.5) {
console.error('Error: --slippage must be > 0 and <= 0.5 (e.g., 0.05 for 5%)')
process.exit(1)
}
break
case '--rpc':
case '-r':
Expand Down Expand Up @@ -348,7 +352,8 @@ async function main() {
console.error(`Error: ${error.message}`)
process.exit(1)
}

const slippageBps = Math.round(args.slippage * 10_000)
const minAmountOut = quote.minAmountOut || (quote.amountOut * BigInt(10_000 - slippageBps) / 10_000n)
const provider = new ethers.JsonRpcProvider(args.rpc)
const safeAddress = config.safe

Expand Down