Add WPF Based Credentials Input Page and Base for other things like Tray Icons#2
Merged
CrawLeyYou merged 17 commits intomainfrom Aug 3, 2025
Merged
Add WPF Based Credentials Input Page and Base for other things like Tray Icons#2CrawLeyYou merged 17 commits intomainfrom
CrawLeyYou merged 17 commits intomainfrom
Conversation
- Need to do Tray Icon functionality now - Error Handling for S3 Connection I think that should be enough for 1.2.1
Owner
Author
|
We need an icon for this project. Any contribution would be appreciated |
Changes: - Code cleanup - Refactor some objects - Fix double cover fetch issue - Fix Textbox overflows Known issues: - There is a bug that crashes the entire Application. Looking for it. - If song has quote in its name it crashes whole database system (which also enables SQL Injection but since this is a local database application it doesnt matter that much). Rich Presence works but no data saved in database.
- Fix for Timestamp issue that uses last song's timestamps on new song - Hide S3 Credentials by default
- Change primary cover method to Apple Music website from iTunes Note: This change doesn't includes the automatic region selector currently. Working on it. (I hope i will not check the ip adress in the end for the region)
Primary Cover Method Fetch Change
Changes: - Update Dependencies - Remove by from the State which contains artists - Use new StatusDisplay method to show artists like Spotify's RPC - Cleanup Note: Currently dependencies update doesn't seem to causes issues still
Owner
Author
|
I think we are done with this no Icon bullshit, also looks like we don't have a problem with the build pipeline and application itself. (I exclude timestamp bug from this i still don't know why it happens) LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.