add tests to pipelines, make arm64, python3.12

.github/workflows/Check.yml

@@ -0,0 +1,37 @@
+name: 'Quality Check'
+
+on:
+  push
+
+permissions:
+  contents: read
+
+defaults:
+  run:
+    shell: bash
+
+concurrency:
+  group: ${{ github.ref }}
+
+env:
+  RUNNER_IMAGE_NAME: github-runner-image
+
+jobs:
+
+  check-code:
+    name: Check Code
+    runs-on: ubuntu-22.04
+    environment: production
+
+    steps:
+    - name: Checkout Branch
+      uses: actions/checkout@v3
+
+    - name: Build Runner Image
+      run: make build-runner-image
+
+    - name: Run Terraform Lint
+      run: make run-command-in-container-lint-terraform
+
+    - name: Run Tests
+      run: make run-command-in-container-run-tests

.github/workflows/Deploy.yml

@@ -1,8 +1,11 @@
 name: 'Deploy Infrastructure'
 
 on:
-  push:
+  workflow_run:
+    workflows: ["Quality Check"]
     branches: [master]
+    types: 
+      - completed
 
 permissions:
   contents: read

.tool-versions

@@ -1,2 +1,2 @@
 terraform 1.4.2
-python 3.8.16
+python 3.12.1

Dockerfile

@@ -8,4 +8,4 @@ RUN wget https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform
 RUN unzip /tmp/terraform_${TERRAFORM_VERSION}_linux_amd64.zip -d /usr/bin
 
 COPY requirements.txt /tmp
-RUN pip install -r /tmp/requirements.txt
+RUN pip install -r /tmp/requirements-dev.txt

Makefile

@@ -16,6 +16,14 @@ validate-terraform:
 	terraform -chdir=terraform validate
 .PHONY: validate-terraform
 
+lint-terraform:
+	terraform -chdir=terraform lint
+.PHONY: lint-terraform
+
+run-tests:
+	pytest -s
+.PHONY: run-tests
+
 deploy:
 	terraform -chdir=terraform init -input=false $(TF_BACKEND_CONFIG)
 	terraform -chdir=terraform plan -input=false -out=tfplan-apply $(TF_VARS)

pytest.ini

@@ -0,0 +1,2 @@
+[pytest]
+pythonpath = . src

terraform/lambda.tf

@@ -42,7 +42,7 @@ resource "aws_lambda_function" "lambda_functions" {
   layers                         = [aws_lambda_layer_version.lambda_layer.arn]
   publish                        = lookup(each.value, "publish_lambda", false)
   reserved_concurrent_executions = lookup(each.value, "reserved_concurrency", -1)
-  architectures                  = ["x86_64"]
+  architectures                  = ["arm64"]
   environment {
     variables = lookup(each.value, "env_variables", {})
   }

terraform/lambda_layer.tf

@@ -1,5 +1,5 @@
 locals {
-  lambda_python_version     = "python3.8"
+  lambda_python_version     = "python3.12"
   requirements_filepath     = "${path.module}/../requirements.txt"
   lambda_layer_zipfile_name = "craftsmen-bot-layer"
 
@@ -24,4 +24,4 @@ resource "aws_lambda_layer_version" "lambda_layer" {
   compatible_runtimes = [local.lambda_python_version]
   depends_on          = [null_resource.build_lambda_layer]
   description         = filemd5(local.requirements_filepath)
-}
+}